You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/11 10:34:00 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF
pvillard31 opened a new pull request #5451:
URL: https://github.com/apache/nifi/pull/5451
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on a change in pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #5451:
URL: https://github.com/apache/nifi/pull/5451#discussion_r726192394
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -136,6 +136,16 @@
.defaultValue("true")
.build();
+ public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+ .name("INCLUDE_CUSTOM_EXTENSIONS")
+ .displayName("Include custom extensions")
+ .description("If set to true, custom extensions (not specified in the CEF specifications) will be "
+ + "included in the generated data/attributes.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
Review comment:
Since it's a boolean property and since we provide a default value, setting it as required does not have any impact in terms of backward compatibility I believe. If someone upgrades, the property will be added with default value = false and it'll be just fine. I set the default value to false to maintain backward compatibility and one would have to change it to true to get the new feature. I believe that everywhere in the NiFi code we always use "required" for boolean properties (unless if the property should depend on flow files attributes but it would not make sense here in my opinion).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5451:
URL: https://github.com/apache/nifi/pull/5451#discussion_r726195648
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -136,6 +136,16 @@
.defaultValue("true")
.build();
+ public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+ .name("INCLUDE_CUSTOM_EXTENSIONS")
+ .displayName("Include custom extensions")
+ .description("If set to true, custom extensions (not specified in the CEF specifications) will be "
+ + "included in the generated data/attributes.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
Review comment:
Thanks for the answer, that makes sense, sounds like this should work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5451:
URL: https://github.com/apache/nifi/pull/5451#discussion_r726186297
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -136,6 +136,16 @@
.defaultValue("true")
.build();
+ public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+ .name("INCLUDE_CUSTOM_EXTENSIONS")
+ .displayName("Include custom extensions")
+ .description("If set to true, custom extensions (not specified in the CEF specifications) will be "
+ + "included in the generated data/attributes.")
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .required(true)
Review comment:
As a new property, should required be set to `false` to maintain backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5451:
URL: https://github.com/apache/nifi/pull/5451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org