You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/22 19:10:08 UTC
[GitHub] [flink] sv3ndk opened a new pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
sv3ndk opened a new pull request #16245:
URL: https://github.com/apache/flink/pull/16245
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
As a resolution for [FLINK-22940](https://issues.apache.org/jira/browse/FLINK-22940), this PR aims at replacing the hard-coded maximum display width currently used by the SQL client with a configurable one.
In the linked ticked we discussed allowing the user to set the max width as unlimited, but on second thought I find is hard to implement since the resulting data may not be materialized => we do not know the maximum width required by the data. I suggest we do not implement this as part of this ticket.
## Brief change log
* Aligned the column width strategy across all modes
In tableau mode, the column width is computed by `PrintUtils.columnWidthsByType()` and depends on the column type (e.g. 10 for a DATE).
In Table and Changelog modes however, all columns defaulted to `MAX_COLUMN_WIDTH`, as provided by `computeColumnWidth(int idx)`, which lead to waste of screen space, inconsistent end-user experience and harder code to maintain.
In order to use the same logic for all modes, I removed the `computeColumnWidth(int idx)` methods and replaced them
with an initialization of the column widths in the constructor that relies on the same `PrintUtils.columnWidthsByType()` method as the Tableau mode.
* Added a new option `sql-client.display.max_column_width` to `SqlClientOptions`
* Added an instance of `ReadableConfig` as a member of `ResultDescriptor`
`ResultDescriptor` already has 2 methods providing access to configuration: `isTableauMode()` and `isStreamingMode()`, that were previously initialized explicitly by the caller.
=> in order to simplify the initialization of `ResultDescriptor` and allow access to all configuration keys, I placed an instance of `ReadableConfig` directly inside it.
Since this class is read-only, I made it public for simplicity.
* Updated the view result in all modes to use the new parameter
In any call to `PrintUtils.columnWidthsByType()` from within the SQL client, the logic is now depending on the new config parameter, obtained via the `ResultDescriptor` instance.
* Updated documentation
I updated the example of display for each mode in the documentation + re-organized the structure a bit in order to move all configuration-related aspects in the "Configuration" section.
* Fixes a few deprecation warnings
Some unit tests were using `org.junit.Assert.assertThat`, which is now deprecated in favour of `org.hamcrest.MatcherAssert.assertThat` => I replaced.
## Verifying this change
See the 2 videos, shoing the old behavior (including inconsistencies of column width across modes) and the new behavior (including usage of the new parameter).
https://user-images.githubusercontent.com/1214071/122984133-f8f38580-d39c-11eb-824d-681f68bb1fb5.mp4
https://user-images.githubusercontent.com/1214071/122984144-fb55df80-d39c-11eb-85b7-a8615b8565c0.mp4
I also validated the existing tests and style with:
```sh
mvn spotless:apply install -pl flink-table/flink-sql-client
```
And validated the documentation updates with
```sh
hugo -b "" serve
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector:no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs / JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392)
* 03f385a7170f0923a72793ac52db3245dace5090 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03f385a7170f0923a72793ac52db3245dace5090 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-868458983
@wuchong , I added the unit test you suggested in `select.q`.
After doing so I'm realizing the truncation logic works as expected but might be a bit confusing to end-users: if some value is wider that the configured max width, if its type has variable length (e.g. String) it gets truncated, whereas if it has a fixed length (e.g. Timestamp) the width of the type is used instead.
This logic is currently implemented in `PrintUtils.columnWidthsByType`, which I've not updated.
Maybe I should update it to make sure the max width is applied to all types? It would impact the SQL client as well as other places of Flink that depend on that class.
What's your opinion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658704948
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultDescriptor.java
##########
@@ -29,21 +35,17 @@
private final boolean isMaterialized;
- private final boolean isTableauMode;
-
- private final boolean isStreamingMode;
+ public final ReadableConfig config;
Review comment:
Thanks for the very kind and useful feed-back @wuchong :)
I'll create the `getMaxColumnWidth()` as you described and hide the `config` as a private field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866260466
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c333291b38c611e884641b75092501bd841109ae (Thu Sep 23 17:51:49 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392)
* 03f385a7170f0923a72793ac52db3245dace5090 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f4ace03817ae80e08bbe28808295db7e1fcc7a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-868945390
Besides, a side note, please do not use "git merge" to update branches, otherwise it's hard to track the commit changes. Please use "git rebase" instead. IntelliJ IDEA provide an easy tool to do git rebase, you can find the tool via `VCS -> Git -> Rebase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pensz commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
pensz commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-868158346
I think this PR contains too many changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658705432
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java
##########
@@ -53,4 +55,16 @@ private SqlClientOptions() {}
.defaultValue(false)
.withDescription(
"Determine whether to output the verbose output to the console. If set the option true, it will print the exception stack. Otherwise, it only output the cause.");
+
+ // Display options
+
+ @Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
+ ConfigOptions.key("sql-client.display.max_column_width")
Review comment:
Ah indeed, I'm not respecting the convention here, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r659116339
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
```
-The **changelog mode** does not materialize results and visualizes the result stream that is produced
-by a [continuous query]({{< ref "docs/dev/table/concepts/dynamic_tables" >}}#continuous-queries) consisting of insertions (`+`) and retractions (`-`).
+The `SET` command allows you to tune the job execution and the sql client behaviour. See [SQL Client Configuration](#sql-client-configuration) below for more details.
-```text
-SET 'sql-client.execution.result-mode' = 'changelog';
-```
+After a query is defined, it can be submitted to the cluster as a long-running, detached Flink job.
+The [configuration section](#configuration) explains how to declare table sources for reading data, how to declare table sinks for writing data, and how to configure other table program properties.
-The **tableau mode** is more like a traditional way which will display the results in the screen directly with a tableau format.
-The displaying content will be influenced by the query execution type(`execution.type`).
-```text
-SET 'sql-client.execution.result-mode' = 'tableau';
-```
-
-Note that when you use this mode with streaming query, the result will be continuously printed on the console. If the input data of
-this query is bounded, the job will terminate after Flink processed all input data, and the printing will also be stopped automatically.
-Otherwise, if you want to terminate a running query, just type `CTRL-C` in this case, the job and the printing will be stopped.
+### Getting help
-You can use the following query to see all the result modes in action:
-
-```sql
-SELECT name, COUNT(*) AS cnt FROM (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name) GROUP BY name;
-```
-
-This query performs a bounded word count example.
-
-In *changelog mode*, the visualized changelog should be similar to:
+The documentation of the SQL client commands can be accessed as follows:
Review comment:
There is already an pending PR for this #16060. Would be great to help to review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658730724
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
```
-The **changelog mode** does not materialize results and visualizes the result stream that is produced
-by a [continuous query]({{< ref "docs/dev/table/concepts/dynamic_tables" >}}#continuous-queries) consisting of insertions (`+`) and retractions (`-`).
+The `SET` command allows you to tune the job execution and the sql client behaviour. See [SQL Client Configuration](#sql-client-configuration) below for more details.
-```text
-SET 'sql-client.execution.result-mode' = 'changelog';
-```
+After a query is defined, it can be submitted to the cluster as a long-running, detached Flink job.
+The [configuration section](#configuration) explains how to declare table sources for reading data, how to declare table sinks for writing data, and how to configure other table program properties.
-The **tableau mode** is more like a traditional way which will display the results in the screen directly with a tableau format.
-The displaying content will be influenced by the query execution type(`execution.type`).
-```text
-SET 'sql-client.execution.result-mode' = 'tableau';
-```
-
-Note that when you use this mode with streaming query, the result will be continuously printed on the console. If the input data of
-this query is bounded, the job will terminate after Flink processed all input data, and the printing will also be stopped automatically.
-Otherwise, if you want to terminate a running query, just type `CTRL-C` in this case, the job and the printing will be stopped.
+### Getting help
-You can use the following query to see all the result modes in action:
-
-```sql
-SELECT name, COUNT(*) AS cnt FROM (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name) GROUP BY name;
-```
-
-This query performs a bounded word count example.
-
-In *changelog mode*, the visualized changelog should be similar to:
+The documentation of the SQL client commands can be accessed as follows:
Review comment:
Ok, I'll remove the output of the `HELP` command and add the link you mentioned.
Maybe we still keep the mention of the `HELP` command though? Even incomplete I find it's useful to know it exists I think.
Would it be useful if I opened another jira ticket for updating the output HELP and make it accurate? For example I learned recently the existence of `ADD JAR` and `SHOW JAR` that seems useful to know but are not documented yet AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658712958
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
Review comment:
Yes, good idea.
I'll also set the execution mode to batch, to avoid showing the `+I` `-U` and `+U` to keep first example as simple as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r659116064
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -85,16 +94,6 @@ public CliChangelogResultView(CliClient client, ResultDescriptor resultDescripto
return Arrays.copyOfRange(resultRow, 1, resultRow.length);
}
- @Override
- protected int computeColumnWidth(int idx) {
Review comment:
I second @sv3ndk 's point here. `computeColumnWidth` is not a good design before, because `tableau` mode doesn't use it. `ResultDescriptor` is a good place to put the initialized column widths and make all modes to have the same getting column width logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
}, {
"hash" : "c333291b38c611e884641b75092501bd841109ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c333291b38c611e884641b75092501bd841109ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03f385a7170f0923a72793ac52db3245dace5090 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549)
* c333291b38c611e884641b75092501bd841109ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #16245:
URL: https://github.com/apache/flink/pull/16245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334)
* 16f4ace03817ae80e08bbe28808295db7e1fcc7a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658738756
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -85,16 +94,6 @@ public CliChangelogResultView(CliClient client, ResultDescriptor resultDescripto
return Arrays.copyOfRange(resultRow, 1, resultRow.length);
}
- @Override
- protected int computeColumnWidth(int idx) {
Review comment:
Hi @pensz .
The PR is 200 lines indeed. About half of it is documentation though, and the previous behavior of column width was implemented differently for all 3 modes, so one factor that made the PR grow is my change to make them all depend on the same logic.
The `computeColumnWidth(int idx)` you refer to would be called for every row, which would be marginally slower I think. In this PR the width are now initialized only once, in the constructor, which seems a natural place for performing initialization.
IMHO, adding methods like `protected int computeColumnWidth(int idx)` adds complexity, since it contributes to making `CliResultView` more different than the tableau mode, and it adds a degree of freedom to the code which might not add that much value, since using the same column width policy everywhere increase the user experience I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-868945087
@sv3ndk , this is as expected. This config option should only affect variable-length types in streaming mode to control the displayed characters. Fixed-length types and all types in batch mode should be able to be displayed in a deterministic column width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658452346
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java
##########
@@ -53,4 +55,16 @@ private SqlClientOptions() {}
.defaultValue(false)
.withDescription(
"Determine whether to output the verbose output to the console. If set the option true, it will print the exception stack. Otherwise, it only output the cause.");
+
+ // Display options
+
+ @Documentation.TableOption(execMode = Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
+ ConfigOptions.key("sql-client.display.max_column_width")
Review comment:
Would be better to use `sql-client.display.max-column-width`, Flink configuration doesn't use `_` as separator.
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultDescriptor.java
##########
@@ -29,21 +35,17 @@
private final boolean isMaterialized;
- private final boolean isTableauMode;
-
- private final boolean isStreamingMode;
+ public final ReadableConfig config;
Review comment:
We can add a `public int getMaxColumnWidth()` method just like `isStreamingMode`, so that we don't need to expose the whole `config`. And users don't need to remember the config name when using, e.g. `resultDescriptor.config.get(DISPLAY_MAX_COLUMN_WIDTH)`.
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
```
-The **changelog mode** does not materialize results and visualizes the result stream that is produced
-by a [continuous query]({{< ref "docs/dev/table/concepts/dynamic_tables" >}}#continuous-queries) consisting of insertions (`+`) and retractions (`-`).
+The `SET` command allows you to tune the job execution and the sql client behaviour. See [SQL Client Configuration](#sql-client-configuration) below for more details.
-```text
-SET 'sql-client.execution.result-mode' = 'changelog';
-```
+After a query is defined, it can be submitted to the cluster as a long-running, detached Flink job.
+The [configuration section](#configuration) explains how to declare table sources for reading data, how to declare table sinks for writing data, and how to configure other table program properties.
-The **tableau mode** is more like a traditional way which will display the results in the screen directly with a tableau format.
-The displaying content will be influenced by the query execution type(`execution.type`).
-```text
-SET 'sql-client.execution.result-mode' = 'tableau';
-```
-
-Note that when you use this mode with streaming query, the result will be continuously printed on the console. If the input data of
-this query is bounded, the job will terminate after Flink processed all input data, and the printing will also be stopped automatically.
-Otherwise, if you want to terminate a running query, just type `CTRL-C` in this case, the job and the printing will be stopped.
+### Getting help
-You can use the following query to see all the result modes in action:
-
-```sql
-SELECT name, COUNT(*) AS cnt FROM (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name) GROUP BY name;
-```
-
-This query performs a bounded word count example.
-
-In *changelog mode*, the visualized changelog should be similar to:
+The documentation of the SQL client commands can be accessed as follows:
Review comment:
Actually, it's not easy to maintain the HELP list (it's not complete too), would be better to just add a link to SQL page `dev/table/sql/overview/` where shows all supported statements.
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
Review comment:
Could you show this display example using `tableau` mode which I think the community is tend to make it as default mode in the future. The `tableau` mode is also more readable than `table` mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r659123441
##########
File path: docs/content/docs/dev/table/sqlClient.md
##########
@@ -60,106 +59,72 @@ or explicitly use `embedded` mode:
./bin/sql-client.sh embedded
```
+See [SQL Client startup options](#sql-client-startup-options) below for more details.
+
### Running SQL Queries
-Once the CLI has been started, you can use the `HELP` command to list all available SQL statements.
-For validating your setup and cluster connection, you can enter your first SQL query and press the `Enter` key to execute it:
+For validating your setup and cluster connection, you can enter the simple query below and press `Enter` to execute it.
```sql
-SELECT 'Hello World';
+SELECT
+ name,
+ COUNT(*) AS cnt
+FROM
+ (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name)
+GROUP BY name;
```
-This query requires no table source and produces a single row result. The CLI will retrieve results
-from the cluster and visualize them. You can close the result view by pressing the `Q` key.
-
-The CLI supports **three modes** for maintaining and visualizing results.
-
-The **table mode** materializes results in memory and visualizes them in a regular, paginated table representation.
-It can be enabled by executing the following command in the CLI:
+The SQL client will retrieve the results from the cluster and visualize them (you can close the result view by pressing the `Q` key):
```text
-SET 'sql-client.execution.result-mode' = 'table';
+ name cnt
+ Alice 1
+ Greg 1
+ Bob 2
```
-The **changelog mode** does not materialize results and visualizes the result stream that is produced
-by a [continuous query]({{< ref "docs/dev/table/concepts/dynamic_tables" >}}#continuous-queries) consisting of insertions (`+`) and retractions (`-`).
+The `SET` command allows you to tune the job execution and the sql client behaviour. See [SQL Client Configuration](#sql-client-configuration) below for more details.
-```text
-SET 'sql-client.execution.result-mode' = 'changelog';
-```
+After a query is defined, it can be submitted to the cluster as a long-running, detached Flink job.
+The [configuration section](#configuration) explains how to declare table sources for reading data, how to declare table sinks for writing data, and how to configure other table program properties.
-The **tableau mode** is more like a traditional way which will display the results in the screen directly with a tableau format.
-The displaying content will be influenced by the query execution type(`execution.type`).
-```text
-SET 'sql-client.execution.result-mode' = 'tableau';
-```
-
-Note that when you use this mode with streaming query, the result will be continuously printed on the console. If the input data of
-this query is bounded, the job will terminate after Flink processed all input data, and the printing will also be stopped automatically.
-Otherwise, if you want to terminate a running query, just type `CTRL-C` in this case, the job and the printing will be stopped.
+### Getting help
-You can use the following query to see all the result modes in action:
-
-```sql
-SELECT name, COUNT(*) AS cnt FROM (VALUES ('Bob'), ('Alice'), ('Greg'), ('Bob')) AS NameTable(name) GROUP BY name;
-```
-
-This query performs a bounded word count example.
-
-In *changelog mode*, the visualized changelog should be similar to:
+The documentation of the SQL client commands can be accessed as follows:
Review comment:
Ok, great! I'll have a look at that one and review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f4ace03817ae80e08bbe28808295db7e1fcc7a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363)
* 780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f4ace03817ae80e08bbe28808295db7e1fcc7a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363)
* 780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866260466
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 (Tue Jun 22 19:12:41 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-868954280
I added one last commit clarifying the documentation of the new option as you suggested and decorated it with `@Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)` instead of `BATCH_STREAMING`.
I'm taking note rebase is preferred over merge, sure, I'll use that in the future then.
As far as I know I think as well the PR is ready to be merged, thanks again for the review and all the feed-back @wuchong :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334)
* 16f4ace03817ae80e08bbe28808295db7e1fcc7a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
}, {
"hash" : "c333291b38c611e884641b75092501bd841109ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19569",
"triggerID" : "c333291b38c611e884641b75092501bd841109ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c333291b38c611e884641b75092501bd841109ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19569)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pensz commented on a change in pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
pensz commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658437027
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -85,16 +94,6 @@ public CliChangelogResultView(CliClient client, ResultDescriptor resultDescripto
return Arrays.copyOfRange(resultRow, 1, resultRow.length);
}
- @Override
- protected int computeColumnWidth(int idx) {
Review comment:
To optimize changelog table result view ,I think computeColumnWIdth with following code will be better.
```
protected int computeColumnWidth(int idx) {
PrintUtils.columnWidthByType(column, ....)
}
```
Another benefit is that constructor of CliResultView is no need to change, subclass of CliResultView can implement computeColumnWIdth differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
}, {
"hash" : "03f385a7170f0923a72793ac52db3245dace5090",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549",
"triggerID" : "03f385a7170f0923a72793ac52db3245dace5090",
"triggerType" : "PUSH"
}, {
"hash" : "c333291b38c611e884641b75092501bd841109ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19569",
"triggerID" : "c333291b38c611e884641b75092501bd841109ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03f385a7170f0923a72793ac52db3245dace5090 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19549)
* c333291b38c611e884641b75092501bd841109ae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19569)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e0f7cb3f507be092d334a8133bcb3daac4b9f03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16245: [FLINK-22940][SQL-CLIENT] Make sql client column max width configurable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16245:
URL: https://github.com/apache/flink/pull/16245#issuecomment-866278518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19334",
"triggerID" : "7e0f7cb3f507be092d334a8133bcb3daac4b9f03",
"triggerType" : "PUSH"
}, {
"hash" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19363",
"triggerID" : "16f4ace03817ae80e08bbe28808295db7e1fcc7a",
"triggerType" : "PUSH"
}, {
"hash" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392",
"triggerID" : "780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 780a5690285b34639ad21e9aa2e4ca3c4ff3d8a5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19392)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org