You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/12 11:28:00 UTC
[GitHub] [hbase-native-client] phrocker opened a new pull request #5: Leverage DOWNLOAD_DEPENDENCIES in docker build system
phrocker opened a new pull request #5:
URL: https://github.com/apache/hbase-native-client/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on a change in pull request #5: HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #5:
URL: https://github.com/apache/hbase-native-client/pull/5#discussion_r439670147
##########
File path: bin/start-docker.sh
##########
@@ -26,8 +26,6 @@ eval "$(docker-machine env dinghy)"
BIN_DIR=$(pushd `dirname "$0"` 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null)
BASE_DIR=$(pushd "${BIN_DIR}/../" 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null)
-${BIN_DIR}/copy-protobuf.sh
Review comment:
git rm these files? I don't think these are needed anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] phrocker commented on a change in pull request #5: HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system
Posted by GitBox <gi...@apache.org>.
phrocker commented on a change in pull request #5:
URL: https://github.com/apache/hbase-native-client/pull/5#discussion_r440079400
##########
File path: bin/start-docker.sh
##########
@@ -26,8 +26,6 @@ eval "$(docker-machine env dinghy)"
BIN_DIR=$(pushd `dirname "$0"` 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null)
BASE_DIR=$(pushd "${BIN_DIR}/../" 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null)
-${BIN_DIR}/copy-protobuf.sh
Review comment:
ah yeah i think I removed them in the other draft PR I have open, but since they are no longer referenced here I should remove them. thanks for pointing this out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] bharathv merged pull request #5: HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #5:
URL: https://github.com/apache/hbase-native-client/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] phrocker commented on pull request #5: HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system
Posted by GitBox <gi...@apache.org>.
phrocker commented on pull request #5:
URL: https://github.com/apache/hbase-native-client/pull/5#issuecomment-643357354
I remembered that I didn't add anything to BUILDING.md. Will do that now to make it clear. may also add a build script too if that's useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org