[jira] [Commented] (HADOOP-12533) Introduce FileNotFoundException in WASB for read and seek API

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984338#comment-14984338 ] 

Steve Loughran commented on HADOOP-12533:
-----------------------------------------

w.r.t closing checks on seek(), I'd lift the check from {{S3AInputStream}}
  
{code}
private void checkNotClosed() throws IOException {
  if (closed) {
    throw new IOException(FSExceptionMessages.STREAM_IS_CLOSED);
  }
}
{code}

call that at the start of the seek()
Then add a check for a negative position

{code}
public synchronized void seek(long pos) throws IOException {
  checkNoClosed()
  if (targetPos < 0) {
    throw new EOFException(FSExceptionMessages.NEGATIVE_SEEK);
  }
{code}

> Introduce FileNotFoundException in WASB for read and seek API
> -------------------------------------------------------------
>
>                 Key: HADOOP-12533
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12533
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 2.8.0
>            Reporter: Dushyanth
>            Assignee: Dushyanth
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12533.001.patch, HADOOP-12533.002.patch, HADOOP-12533.003.patch
>
>
> Currently WASB throws a IOException in read and seek API for both Block and Page blobs for scenarios where the backing blobs do not exists. This creates problems for applications like HBase which expect a FileNotFoundException in these scenarios. 
> The fix for the problem is to check if the exceptions from Azure storage is because for Blob not found and throw FileNotFound exception if that is the case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)