You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/05/03 01:35:32 UTC

[GitHub] [incubator-heron] Code0x58 opened a new pull request #3522: Python 3 upgrade

Code0x58 opened a new pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522


   This is a WIP continuing from where there the last branch left off


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] Code0x58 commented on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
Code0x58 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-640052470


   I just pushed a change that should get you at least a little further. I'm still working on getting the integration to run against k8s, so will hopefully have some time for that this weekend


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653998127


   All good on Darwin and Debian10 platforms.  👍 @Code0x58 
   
   ```
   
   
   $ docker --version
   Docker version 19.03.8, build afacb8b
   
   git clone https://github.com/apache/incubator-heron.git
   git remote add Code0x58 https://github.com/Code0x58/incubator-heron.git 
   git fetch Code0x58
   git checkout --track Code0x58/python-3-upgrade
   
   # Darwin
   
   $ sw_vers
   ProductName:	Mac OS X
   ProductVersion:	10.15.5
   BuildVersion:	19F101
   
   $ heron submit local  ~/.heron/examples/heron-api-examples.jar org.apache.heron.examples.api.AckingTopology acking
   
   $ heron kill local acking
   
   # Debian10
   ./docker/scripts/build-artifacts.sh debian10 0.0.0 ~/heron-release
   
   $ docker run -it --rm  -p 8889:8889 heron/heron:0.0.0 bash
   
   #All of the following commands were ran from inside the running container
   $ supervisord
   
   $ heron submit sandbox  ./examples/heron-api-examples.jar org.apache.heron.examples.api.AckingTopology acking
   
   $ heron kill sandbox acking
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189


   I did a local test on OSX by creating the install scripts.  So far it did not work as expected. I do think we are very close.  I installed Heron by the following:
   
   **Note:** All commands are ran from the root directory of the project
   ```
   $ bazel build --config=darwin_nostyle scripts/packages:binpkgs
   ````
   The above command's output is the install scripts. The location of the scripts will be echoed to the terminal.  Typically something like:
   ```
    Target //scripts/packages:binpkgs up-to-date:
     bazel-bin/scripts/packages/heron-install.sh
   ```
      I then installed them.
   ```
   $ ./bazel-bin/scripts/packages/heron-install.sh --user
   ```
   I checked the heron version command.  All good.
   ```
   $  heron version
   heron.build.git.revision : 1f80d5a20fbd146597de7dab3c94816a602239fd
   heron.build.git.status : Clean
   heron.build.host : Joshs-MacBook-Pro-2.local
   heron.build.time : Fri May 29 21:11:31 CDT 2020
   heron.build.timestamp : 1590804691000
   heron.build.user : joshfischer
   heron.build.version : python-3-upgrade
   ```
   Then I started the tracker.  All good.
   ```
   $ heron-tracker
   [2020-05-29 21:42:22 -0500] [INFO]: Connecting to file state with rootpath: /Users/joshfischer/.herondata/repository/state/local
   [2020-05-29 21:42:22 -0500] [INFO]: Tracker has started
   [2020-05-29 21:42:22 -0500] [INFO]: Running on port: 8888
   [2020-05-29 21:42:22 -0500] [INFO]: Using config file: /Users/joshfischer/.heron/conf/heron_tracker.yaml
   [2020-05-29 21:42:22 -0500] [INFO]: Using state manager:
   	type: file
   	name: local
   	rootpath: ~/.herondata/repository/state/local
   	tunnelhost: 127.0.0.1
   ```
   
   When trying to start the UI piece of Heron it looks like it could not find the `release.yaml` file.  See below:
   ```
   $ heron-ui
   Traceback (most recent call last):
     File ".bootstrap/pex/pex.py", line 396, in execute
     File ".bootstrap/pex/pex.py", line 328, in _wrap_coverage
     File ".bootstrap/pex/pex.py", line 359, in _wrap_profiling
     File ".bootstrap/pex/pex.py", line 447, in _execute
     File ".bootstrap/pex/pex.py", line 544, in execute_entry
     File ".bootstrap/pex/pex.py", line 551, in execute_module
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 208, in run_module
       return _run_code(code, {}, init_globals, run_name, mod_spec)
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
       exec(code, run_globals)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/main.py", line 40, in <module>
       from heron.tools.ui.src.python import args
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/args.py", line 24, in <module>
       import heron.tools.ui.src.python.consts as consts
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/consts.py", line 35, in <module>
       VERSION = common_config.get_version_number(zipped_pex=True)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/common/src/python/utils/config.py", line 476, in get_version_number
       with open(release_file) as release_info:
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/joshfischer/.heron/scripts/packages/release.yaml'
   ```
   However, the `release.yaml` is in the `~/.heron` directory.  Just not in that location.
   ```
   cd ~/.heron/
   bin/          dist/         examples/     lib/          
   conf/         etc/          include/      release.yaml 
   ```
   
   I may have to rebuild master and see if it expects the `release.yaml` to be in the same location.  Not sure yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189


   I did a local test on OSX by creating the install scripts.  So far it did not work as expected. I do think we are very close.  I installed Heron by the following:
   
   **Note:** All commands are ran from the root directory of the project
   ```
   $ bazel build --config=darwin_nostyle scripts/packages:binpkgs
   ````
   The above command's output is the install scripts. The location of the scripts will be echoed to the terminal.  Typically something like:
   ```
    Target //scripts/packages:binpkgs up-to-date:
     bazel-bin/scripts/packages/heron-install.sh
   ```
      I then executed them to install Heron.
   ```
   $ ./bazel-bin/scripts/packages/heron-install.sh --user
   ```
   I checked the heron version command.  All good.
   ```
   $  heron version
   heron.build.git.revision : 1f80d5a20fbd146597de7dab3c94816a602239fd
   heron.build.git.status : Clean
   heron.build.host : Joshs-MacBook-Pro-2.local
   heron.build.time : Fri May 29 21:11:31 CDT 2020
   heron.build.timestamp : 1590804691000
   heron.build.user : joshfischer
   heron.build.version : python-3-upgrade
   ```
   Then I started the tracker.  All good.
   ```
   $ heron-tracker
   [2020-05-29 21:42:22 -0500] [INFO]: Connecting to file state with rootpath: /Users/joshfischer/.herondata/repository/state/local
   [2020-05-29 21:42:22 -0500] [INFO]: Tracker has started
   [2020-05-29 21:42:22 -0500] [INFO]: Running on port: 8888
   [2020-05-29 21:42:22 -0500] [INFO]: Using config file: /Users/joshfischer/.heron/conf/heron_tracker.yaml
   [2020-05-29 21:42:22 -0500] [INFO]: Using state manager:
   	type: file
   	name: local
   	rootpath: ~/.herondata/repository/state/local
   	tunnelhost: 127.0.0.1
   ```
   
   When trying to start the UI piece of Heron it looks like it could not find the `release.yaml` file.  See below:
   ```
   $ heron-ui
   Traceback (most recent call last):
     File ".bootstrap/pex/pex.py", line 396, in execute
     File ".bootstrap/pex/pex.py", line 328, in _wrap_coverage
     File ".bootstrap/pex/pex.py", line 359, in _wrap_profiling
     File ".bootstrap/pex/pex.py", line 447, in _execute
     File ".bootstrap/pex/pex.py", line 544, in execute_entry
     File ".bootstrap/pex/pex.py", line 551, in execute_module
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 208, in run_module
       return _run_code(code, {}, init_globals, run_name, mod_spec)
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
       exec(code, run_globals)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/main.py", line 40, in <module>
       from heron.tools.ui.src.python import args
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/args.py", line 24, in <module>
       import heron.tools.ui.src.python.consts as consts
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/consts.py", line 35, in <module>
       VERSION = common_config.get_version_number(zipped_pex=True)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/common/src/python/utils/config.py", line 476, in get_version_number
       with open(release_file) as release_info:
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/joshfischer/.heron/scripts/packages/release.yaml'
   ```
   However, the `release.yaml` is in the `~/.heron` directory.  Just not in that location.
   ```
   cd ~/.heron/
   bin/          dist/         examples/     lib/          
   conf/         etc/          include/      release.yaml 
   ```
   
   I may have to rebuild master and see if it expects the `release.yaml` to be in the same location.  Not sure yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-654528065


   I think we are ready to merge. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] Code0x58 commented on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
Code0x58 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636527833


   Thanks @joshfischer1108 for checking it out! I pushed 5efa344 to fix that, which at least seems to run without any toplogies (yet to try with). I'm making some basic bests for the helm chart with everything scaled down to one, and can try adding extra steps you do


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu edited a comment on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653693019






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nwangtw commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
nwangtw commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-654394732


   > @nwangtw / @nlu90 could both of you test this out before we merge?
   
   ack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653911729






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653911729


   I'm testing this branch on the `darwin`/`debian10` platforms today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu edited a comment on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653693019


   Followed the steps in https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189, the Tracker and UI look good to me. 
   Tried a local simple Python topology, and the job worked well.
   My environment: Ubuntu 20.04, Python 3.8.2, with #3555


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189


   I did a local test on OSX by creating the install scripts.  So far it did not work as expected. I do think we are very close.  I installed Heron by the following:
   
   **Note:** All commands are ran from the root directory of the project
   ```
   $ bazel build --config=darwin_nostyle scripts/packages:binpkgs
   ````
   The above command's output is the install scripts. The location of the scripts will be echoed to the terminal.  Typically something like:
   ```
    Target //scripts/packages:binpkgs up-to-date:
     bazel-bin/scripts/packages/heron-install.sh
   ```
      I then executed them to install Heron.
   ```
   $ ./bazel-bin/scripts/packages/heron-install.sh --user
   ```
   I checked the heron version command.  All good.
   ```
   $  heron version
   heron.build.git.revision : 1f80d5a20fbd146597de7dab3c94816a602239fd
   heron.build.git.status : Clean
   heron.build.host : Joshs-MacBook-Pro-2.local
   heron.build.time : Fri May 29 21:11:31 CDT 2020
   heron.build.timestamp : 1590804691000
   heron.build.user : joshfischer
   heron.build.version : python-3-upgrade
   ```
   Then I started the tracker.  All good.
   ```
   $ heron-tracker
   [2020-05-29 21:42:22 -0500] [INFO]: Connecting to file state with rootpath: /Users/joshfischer/.herondata/repository/state/local
   [2020-05-29 21:42:22 -0500] [INFO]: Tracker has started
   [2020-05-29 21:42:22 -0500] [INFO]: Running on port: 8888
   [2020-05-29 21:42:22 -0500] [INFO]: Using config file: /Users/joshfischer/.heron/conf/heron_tracker.yaml
   [2020-05-29 21:42:22 -0500] [INFO]: Using state manager:
   	type: file
   	name: local
   	rootpath: ~/.herondata/repository/state/local
   	tunnelhost: 127.0.0.1
   ```
   
   I had issues when starting the UI tool of Heron it looks like it could not find the `release.yaml` file.  See below:
   ```
   $ heron-ui
   Traceback (most recent call last):
     File ".bootstrap/pex/pex.py", line 396, in execute
     File ".bootstrap/pex/pex.py", line 328, in _wrap_coverage
     File ".bootstrap/pex/pex.py", line 359, in _wrap_profiling
     File ".bootstrap/pex/pex.py", line 447, in _execute
     File ".bootstrap/pex/pex.py", line 544, in execute_entry
     File ".bootstrap/pex/pex.py", line 551, in execute_module
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 208, in run_module
       return _run_code(code, {}, init_globals, run_name, mod_spec)
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
       exec(code, run_globals)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/main.py", line 40, in <module>
       from heron.tools.ui.src.python import args
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/args.py", line 24, in <module>
       import heron.tools.ui.src.python.consts as consts
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/consts.py", line 35, in <module>
       VERSION = common_config.get_version_number(zipped_pex=True)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/common/src/python/utils/config.py", line 476, in get_version_number
       with open(release_file) as release_info:
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/joshfischer/.heron/scripts/packages/release.yaml'
   ```
   However, the `release.yaml` is in the `~/.heron` directory.  Just not in that location.
   ```
   cd ~/.heron/
   bin/          dist/         examples/     lib/          
   conf/         etc/          include/      release.yaml 
   ```
   
   I may have to rebuild master and see if it expects the `release.yaml` to be in the same location.  Not sure yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-643028654


   @Code0x58 I haven't forgotten about your PR.  I'm trying to wrap up some work I had ahead of this so that we can start a new release candidate vote.   I assumed it would have been done sooner, but I had forgotten about one last task. Once I have that fixed. I'll come back to this.  Hope this is ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-639967918


   Thanks @Code0x58 .  I'll do some more checking this weekend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu commented on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653693019


   Followed the steps in https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189, the Tracker and UI look good to me. 
   My environment: Ubuntu 20.04, Python 3.8.2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653911729


   I'm testing this branch on the `darwin` platform today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189


   I did a local test on OSX by creating the install scripts.  So far it did not work as expected. I do think we are very close.  I installed Heron by the following:
   
   **Note:** All commands are ran from the root directory of the project
   ```
   $ bazel build --config=darwin_nostyle scripts/packages:binpkgs
   ````
   The above command's output is the install scripts. The location of the scripts will be echoed to the terminal.  Typically something like:
   ```
    Target //scripts/packages:binpkgs up-to-date:
     bazel-bin/scripts/packages/heron-install.sh
   ```
      I then executed them to install Heron.
   ```
   $ ./bazel-bin/scripts/packages/heron-install.sh --user
   ```
   I checked the heron version command.  All good.
   ```
   $  heron version
   heron.build.git.revision : 1f80d5a20fbd146597de7dab3c94816a602239fd
   heron.build.git.status : Clean
   heron.build.host : Joshs-MacBook-Pro-2.local
   heron.build.time : Fri May 29 21:11:31 CDT 2020
   heron.build.timestamp : 1590804691000
   heron.build.user : joshfischer
   heron.build.version : python-3-upgrade
   ```
   Then I started the tracker.  All good.
   ```
   $ heron-tracker
   [2020-05-29 21:42:22 -0500] [INFO]: Connecting to file state with rootpath: /Users/joshfischer/.herondata/repository/state/local
   [2020-05-29 21:42:22 -0500] [INFO]: Tracker has started
   [2020-05-29 21:42:22 -0500] [INFO]: Running on port: 8888
   [2020-05-29 21:42:22 -0500] [INFO]: Using config file: /Users/joshfischer/.heron/conf/heron_tracker.yaml
   [2020-05-29 21:42:22 -0500] [INFO]: Using state manager:
   	type: file
   	name: local
   	rootpath: ~/.herondata/repository/state/local
   	tunnelhost: 127.0.0.1
   ```
   
   I had issues when starting the UI tool of Heron. It looks like it could not find the `release.yaml` file.  See below:
   ```
   $ heron-ui
   Traceback (most recent call last):
     File ".bootstrap/pex/pex.py", line 396, in execute
     File ".bootstrap/pex/pex.py", line 328, in _wrap_coverage
     File ".bootstrap/pex/pex.py", line 359, in _wrap_profiling
     File ".bootstrap/pex/pex.py", line 447, in _execute
     File ".bootstrap/pex/pex.py", line 544, in execute_entry
     File ".bootstrap/pex/pex.py", line 551, in execute_module
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 208, in run_module
       return _run_code(code, {}, init_globals, run_name, mod_spec)
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
       exec(code, run_globals)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/main.py", line 40, in <module>
       from heron.tools.ui.src.python import args
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/args.py", line 24, in <module>
       import heron.tools.ui.src.python.consts as consts
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/consts.py", line 35, in <module>
       VERSION = common_config.get_version_number(zipped_pex=True)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/common/src/python/utils/config.py", line 476, in get_version_number
       with open(release_file) as release_info:
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/joshfischer/.heron/scripts/packages/release.yaml'
   ```
   However, the `release.yaml` is in the `~/.heron` directory.  Just not in that location.
   ```
   cd ~/.heron/
   bin/          dist/         examples/     lib/          
   conf/         etc/          include/      release.yaml 
   ```
   
   I may have to rebuild master and see if it expects the `release.yaml` to be in the same location.  Not sure yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-654362364


   @nwangtw / @nlu90 could both of you test this out before we merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 edited a comment on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-639967918


   Thanks @Code0x58 .  I'll do some more checking/testing this weekend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu edited a comment on pull request #3522: WIP: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653693019


   Followed the steps in https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189, the Tracker and UI look good to me. 
   Tried a simple Python topology as well. The job worked well.
   My environment: Ubuntu 20.04, Python 3.8.2, with #3555


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis merged pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] huijunwu commented on pull request #3522: Python 3 upgrade

Posted by GitBox <gi...@apache.org>.
huijunwu commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-653891925


   Test with minikue. Looks good
   
   ```
   $ hostnamectl
            Icon name: computer-desktop
              Chassis: desktop
     Operating System: Ubuntu 20.04 LTS
               Kernel: Linux 5.4.0-40-generic
         Architecture: x86-64
   $ docker --version
   Docker version 19.03.8, build afacb8b7f0
   
   git clone https://github.com/apache/incubator-heron.git
   git remote add Code0x58 https://github.com/Code0x58/incubator-heron.git 
   git fetch Code0x58
   git checkout --track Code0x58/python-3-upgrade
   
   ./docker/scripts/build-artifacts.sh ubuntu20.04 0.0.0 ~/heron-release
   
   $ kubectl version --client
   Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.5", GitCommit:"e6503f8d8f769ace2f338794c914a96fc335df0f", GitTreeState:"clean", BuildDate:"2020-06-26T03:47:41Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
   $ minikube version
   minikube version: v1.11.0
   commit: 57e2f55f47effe9ce396cea42a1e0eb4f611ebbd
   
   eval $(minikube -p minikube docker-env)
   ./docker/scripts/build-docker.sh ubuntu20.04 0.0.0 ~/heron-release
   
   # cluster
   DIR=./deploy/kubernetes/minikube
   sed 's!heron/heron:latest!heron/heron:0.0.0!g' ${DIR}/zookeeper.yaml > /tmp/zookeeper.yaml
   sed 's!heron/heron:latest!heron/heron:0.0.0!g' ${DIR}/tools.yaml > /tmp/tools.yaml
   sed 's!heron/heron:latest!heron/heron:0.0.0!g' ${DIR}/apiserver.yaml > /tmp/apiserver.yaml
   
   kubectl create -f /tmp/zookeeper.yaml
   kubectl get pods
   kubectl create -f ${DIR}/bookkeeper.yaml
   kubectl create -f /tmp/tools.yaml
   kubectl create -f /tmp/apiserver.yaml
   
   # submit a job
   kubectl proxy -p 8001 &
   
   curl http://localhost:8001/api/v1/namespaces/default/services/heron-apiserver:9000/proxy/api/v1/version
   heron config kubernetes set service_url http://localhost:8001/api/v1/namespaces/default/services/heron-apiserver:9000/proxy
   heron submit kubernetes ~/.heron/examples/heron-api-examples.jar org.apache.heron.examples.api.AckingTopology acking
   heron kill kubernetes acking
   
   # clean
   kubectl delete -f /tmp/zookeeper.yaml
   kubectl delete -f ${DIR}/bookkeeper.yaml
   kubectl delete -f /tmp/tools.yaml
   kubectl delete -f /tmp/apiserver.yaml
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org