[GitHub] [spark] zhenlineo commented on a diff in pull request #39078: [SPARK-41534][CONNECT][SQL] Setup initial client module for Spark Connect

[GitBox <gi...@apache.org>]

zhenlineo commented on code in PR #39078:
URL: https://github.com/apache/spark/pull/39078#discussion_r1051273721


##########
project/SparkBuild.scala:
##########
@@ -1433,7 +1492,10 @@ object CopyDependencies {
           if (jar.getName.contains("spark-connect") &&
             !SbtPomKeys.profiles.value.contains("noshade-connect")) {
             Files.copy(fid.toPath, destJar.toPath)
-          } else if (jar.getName.contains("spark-protobuf") &&
+          } else if (jar.getName.contains("connect-client") &&
+            !SbtPomKeys.profiles.value.contains("noshade-protobuf")) {

Review Comment:
   Just double check if you really meant to use `spark-protobuf` or it is a copy-past typo?
   The values to these three jars are a bit magical.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org