You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/09/06 21:54:59 UTC
[GitHub] [incubator-druid] clintropolis commented on a change in pull
request #8230: Fix dependency analyze warnings
clintropolis commented on a change in pull request #8230: Fix dependency analyze warnings
URL: https://github.com/apache/incubator-druid/pull/8230#discussion_r321923143
##########
File path: licenses.yaml
##########
@@ -1038,11 +1004,26 @@ notice: |
---
+name: Netty
+license_category: binary
+module: java-core
+license_name: Apache License version 2.0
+version: 4.1.30.Final
+libraries:
+ - io.netty: netty-buffer
+ - io.netty: netty-codec
+ - io.netty: netty-codec-http
+ - io.netty: netty-common
+ - io.netty: netty-handler
+ - io.netty: netty-transport
Review comment:
There is already an entry for this version of Netty, https://github.com/apache/incubator-druid/blob/557f2cc0395c6f9b1082ee8a7742b70664dba45a/licenses.yaml#L761. Additionally, Netty has a `NOTICE`, I think we need to add the text of it from this version similar to how 4.1.29 is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org