You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/07/21 10:26:05 UTC
[jira] [Commented] (HADOOP-10787) Rename/remove non-HADOOP_*, etc
from the shell scripts
[ https://issues.apache.org/jira/browse/HADOOP-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634760#comment-14634760 ]
Hadoop QA commented on HADOOP-10787:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 59s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac | 7m 36s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck (v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | common tests | 22m 25s | Tests passed in hadoop-common. |
| {color:green}+1{color} | common tests | 1m 40s | Tests passed in hadoop-kms. |
| {color:green}+1{color} | tools/hadoop tests | 0m 52s | Tests passed in hadoop-sls. |
| {color:red}-1{color} | hdfs tests | 161m 4s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests | 3m 37s | Tests passed in hadoop-hdfs-httpfs. |
| | | 224m 16s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.ha.TestStandbyIsHot |
| | hadoop.hdfs.TestDistributedFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12746261/HADOOP-10787.00.patch |
| Optional Tests | javadoc javac unit shellcheck |
| git revision | trunk / df1e8ce |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/artifact/patchprocess/testrun_hadoop-common.txt |
| hadoop-kms test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/artifact/patchprocess/testrun_hadoop-kms.txt |
| hadoop-sls test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/artifact/patchprocess/testrun_hadoop-sls.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| hadoop-hdfs-httpfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7307/console |
This message was automatically generated.
> Rename/remove non-HADOOP_*, etc from the shell scripts
> ------------------------------------------------------
>
> Key: HADOOP-10787
> URL: https://issues.apache.org/jira/browse/HADOOP-10787
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Labels: scripts
> Attachments: HADOOP-10787.00.patch
>
>
> We should make an effort to clean up the shell env var name space by removing unsafe variables. See comments for list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)