[jira] [Commented] (FLINK-10061) Fix unsupported configuration in KafkaTableSink

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569434#comment-16569434 ] 

ASF GitHub Bot commented on FLINK-10061:
----------------------------------------

tragicjun opened a new pull request #6495: [FLINK-10061] [kafka] Fix unsupported configuration in KafkaTableSink
URL: https://github.com/apache/flink/pull/6495
 
 
   ## What is the purpose of the change
   
   When using KafkaTableSink in "Table.writeToSink(), the following exception is thrown:
   `java.lang.UnsupportedOperationException: Reconfiguration of this sink is not supported.`
   
   In `Table.writeToSink()` an invocation to "TableSink.configure()" is made to configure parsed fieldNames and fieldTypes from table query. However, `KafkaTableSink.configure()` doesn't support reconfiguration once a fixed table schema has already been configured. This pull request tries to fix the issue: a quick fix is to change the semantics of "KafkaTableSink.configure()".
   
   ## Brief change log
   
     - Allow reconfiguration to KafkaTableSink even when a fixed table schema exists. The semantics of this configuration therefore is to verify if configured fieldTypes matches with the fieldTypes declared by the fixed table schema. A `ValidationException` would be thrown if they do not match.
   
   ## Verifying this change
   
   This change is a trivial fix without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix unsupported configuration in KafkaTableSink
> -----------------------------------------------
>
>                 Key: FLINK-10061
>                 URL: https://issues.apache.org/jira/browse/FLINK-10061
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.6.0
>            Reporter: Jun Zhang
>            Assignee: Jun Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> When using KafkaTableSink in "table.writeToSink(), the following exception is thrown:
> {quote} java.lang.UnsupportedOperationException: Reconfiguration of this sink is not supported.
> {quote}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)