You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2015/04/30 12:04:55 UTC

[GitHub] incubator-brooklyn pull request: fix java.sysprops string

GitHub user andreaturli opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/618

    fix java.sysprops string

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andreaturli/incubator-brooklyn fix/getting-started-blueprint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #618
    
----
commit 8075889d19dda92c52a3be381a3fc1162d5f4615
Author: Andrea Turli <an...@gmail.com>
Date:   2015-04-30T09:41:15Z

    fix java.sysprops string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fix java.sysprops string

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/618#issuecomment-97727362
  
    good fix.  done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fix java.sysprops string

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/618#discussion_r29506665
  
    --- Diff: docs/guide/start/_my-web-cluster.yaml ---
    @@ -10,7 +10,7 @@ services:
         wars.root: http://search.maven.org/remotecontent?filepath=io/brooklyn/example/brooklyn-example-hello-world-sql-webapp/0.6.0/brooklyn-example-hello-world-sql-webapp-0.6.0.war
         java.sysprops:
           brooklyn.example.db.url: >
    -        $brooklyn:formatString("jdbc:%s%s?user=%s\\&password=%s",
    +        $brooklyn:formatString("jdbc:%s%s?user=%s&password=%s",
    --- End diff --
    
    Annoyingly this will fix it for Tomcat, but will break it for JBoss7!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: fix java.sysprops string

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/618


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---