You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/27 06:33:39 UTC
[I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
laglangyue opened a new issue, #885:
URL: https://github.com/apache/incubator-pekko/issues/885
<!--
Please report issues regarding specific projects in their respective issue trackers, e.g.:
- Pekko HTTP: https://github.com/apache/incubator-pekko-http/issues
- Pekko Connectors: https://github.com/apache/incubator-pekko-connectors/issues
- Pekko Persistence Cassandra Plugin: https://github.com/apache/incubator-pekko-persistence-cassandra/issues
- ...
Please explain your use case precisely, and if possible provide an example snippet.
Thanks for contributing!
-->
like this sreenshot, which is from apache seatunnel
this link is not added by developer, and it's automatic, maybe by github.
this link can help us to trace history and reasons for changes and obtain more information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870208035
I understand, my point is that even the PR link (i.e. the `#285` which you highlighted in the screenshot) is just a minor convenience if you copy the git hash of the commit and paste it in the search bar of the github repo, github will bring you to the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #885: Feature: Add pr link to git message automaticly by github
URL: https://github.com/apache/incubator-pekko/issues/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870195674
> Do note that the PR link in the git message is largely irrelevant because the github ui allows you to search by the commit hash and when you do this it will also provide the PR behind that commit hash, even though I do admit that it is a nice touch.
>
> Another thing to keep note of is that technically speaking according to ASF policy, github is a convenience and hence ASF projects shouldn't be tied to github. There is gitbox for that.
Infact, we won't actually add a link to the git message, we just added the `PR ID`.
such as this, the idea vcs plugin will translator the `PR ID` to a linkļ¼This is a convenient operation to review history.
as pjfanning said, use `squash merge` would get the pr-id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870089482
I see, so I just need do a squash merge !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870066107
You get the PR link if you squash merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870013971
then add vcs.xml
```xml
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="VcsDirectoryMappings">
<mapping directory="$PROJECT_DIR$" vcs="Git"/>
</component>
<component name="IssueNavigationConfiguration">
<option name="links">
<list>
<IssueNavigationLink>
<option name="issueRegexp" value="#(\d+)"/>
<option name="linkRegexp" value="https://github.com/apache/seatunnel/pull/$1"/>
</IssueNavigationLink>
</list>
</option>
</component>
</project>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870122560
Do note that the PR link in the git message is largely irrelevant because the github ui allows you to search by the commit hash and when you do this it will also provide the PR behind that commit hash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature: Add pr link to git message automaticly by github [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #885:
URL: https://github.com/apache/incubator-pekko/issues/885#issuecomment-1870016065
@mdedetrich @pjfanning ping, I can't access the setting tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org