You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2016/02/16 16:25:32 UTC
svn commit: r1730699 - in /pdfbox/trunk/pdfbox/src:
main/java/org/apache/pdfbox/pdmodel/interactive/form/
test/java/org/apache/pdfbox/pdmodel/interactive/form/
Author: msahyoun
Date: Tue Feb 16 15:25:31 2016
New Revision: 1730699
URL: http://svn.apache.org/viewvc?rev=1730699&view=rev
Log:
PDFBOX-3234: rename PDCheckbox to PDCheckBox to match naming conventions
Added:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckBox.java
- copied, changed from r1730696, pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java
Removed:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldFactory.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestCheckBox.java
Copied: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckBox.java (from r1730696, pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java)
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckBox.java?p2=pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckBox.java&p1=pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java&r1=1730696&r2=1730699&rev=1730699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckBox.java Tue Feb 16 15:25:31 2016
@@ -31,14 +31,14 @@ import org.apache.pdfbox.pdmodel.interac
* @author Ben Litchfield
* @author sug
*/
-public final class PDCheckbox extends PDButton
+public final class PDCheckBox extends PDButton
{
/**
* @see PDField#PDField(PDAcroForm)
*
* @param acroForm The acroform.
*/
- public PDCheckbox(PDAcroForm acroForm)
+ public PDCheckBox(PDAcroForm acroForm)
{
super(acroForm);
}
@@ -50,7 +50,7 @@ public final class PDCheckbox extends PD
* @param field the PDF object to represent as a field.
* @param parent the parent node of the node
*/
- PDCheckbox(PDAcroForm acroForm, COSDictionary field, PDNonTerminalField parent)
+ PDCheckBox(PDAcroForm acroForm, COSDictionary field, PDNonTerminalField parent)
{
super(acroForm, field, parent);
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldFactory.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldFactory.java?rev=1730699&r1=1730698&r2=1730699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldFactory.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldFactory.java Tue Feb 16 15:25:31 2016
@@ -104,7 +104,7 @@ final class PDFieldFactory
}
else
{
- return new PDCheckbox(form, field, parent);
+ return new PDCheckBox(form, field, parent);
}
}
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java?rev=1730699&r1=1730698&r2=1730699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java Tue Feb 16 15:25:31 2016
@@ -61,7 +61,7 @@ public class PDButtonTest
@Test
public void createCheckBox()
{
- PDButton buttonField = new PDCheckbox(acroForm);
+ PDButton buttonField = new PDCheckBox(acroForm);
assertEquals(buttonField.getFieldType(), buttonField.getCOSObject().getNameAsString(COSName.FT));
assertEquals(buttonField.getFieldType(), "Btn");
@@ -94,7 +94,7 @@ public class PDButtonTest
@Test
public void retrieveAcrobatCheckBoxProperties() throws IOException
{
- PDCheckbox checkbox = (PDCheckbox) acrobatAcroForm.getField("Checkbox");
+ PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
assertNotNull(checkbox);
assertEquals(checkbox.getOnValue(), "Yes");
assertEquals(checkbox.getOnValues().size(), 1);
@@ -104,7 +104,7 @@ public class PDButtonTest
@Test
public void testAcrobatCheckBoxProperties() throws IOException
{
- PDCheckbox checkbox = (PDCheckbox) acrobatAcroForm.getField("Checkbox");
+ PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
assertEquals(checkbox.getValue(), "");
assertEquals(checkbox.isChecked(), false);
@@ -122,7 +122,7 @@ public class PDButtonTest
assertEquals(checkbox.isChecked(), false);
assertEquals(checkbox.getCOSObject().getDictionaryObject(COSName.AS), COSName.Off);
- checkbox = (PDCheckbox) acrobatAcroForm.getField("Checkbox-DefaultValue");
+ checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox-DefaultValue");
assertEquals(checkbox.getDefaultValue(), checkbox.getOnValue());
checkbox.setDefaultValue("Off");
@@ -135,20 +135,20 @@ public class PDButtonTest
PDField checkbox = acrobatAcroForm.getField("Checkbox");
checkbox.setValue("Yes");
- assertEquals(checkbox.getValueAsString(), ((PDCheckbox) checkbox).getOnValue());
- assertEquals(((PDCheckbox) checkbox).isChecked(), true);
+ assertEquals(checkbox.getValueAsString(), ((PDCheckBox) checkbox).getOnValue());
+ assertEquals(((PDCheckBox) checkbox).isChecked(), true);
assertEquals(checkbox.getCOSObject().getDictionaryObject(COSName.AS), COSName.YES);
checkbox.setValue("Off");
assertEquals(checkbox.getValueAsString(), COSName.Off.getName());
- assertEquals(((PDCheckbox) checkbox).isChecked(), false);
+ assertEquals(((PDCheckBox) checkbox).isChecked(), false);
assertEquals(checkbox.getCOSObject().getDictionaryObject(COSName.AS), COSName.Off);
}
@Test
public void testAcrobatCheckBoxGroupProperties() throws IOException
{
- PDCheckbox checkbox = (PDCheckbox) acrobatAcroForm.getField("CheckboxGroup");
+ PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("CheckboxGroup");
assertEquals(checkbox.getValue(), "");
assertEquals(checkbox.isChecked(), false);
@@ -219,7 +219,7 @@ public class PDButtonTest
@Test(expected=IllegalArgumentException.class)
public void setCheckboxInvalidValue() throws IOException
{
- PDCheckbox checkbox = (PDCheckbox) acrobatAcroForm.getField("Checkbox");
+ PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
// Set a value which doesn't match the radio button list
checkbox.setValue("InvalidValue");
}
@@ -227,7 +227,7 @@ public class PDButtonTest
@Test(expected=IllegalArgumentException.class)
public void setCheckboxGroupInvalidValue() throws IOException
{
- PDCheckbox checkbox = (PDCheckbox) acrobatAcroForm.getField("CheckboxGroup");
+ PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("CheckboxGroup");
// Set a value which doesn't match the radio button list
checkbox.setValue("InvalidValue");
}
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestCheckBox.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestCheckBox.java?rev=1730699&r1=1730698&r2=1730699&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestCheckBox.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/TestCheckBox.java Tue Feb 16 15:25:31 2016
@@ -77,7 +77,7 @@ public class TestCheckBox extends TestCa
{
doc = new PDDocument();
PDAcroForm form = new PDAcroForm( doc );
- PDCheckbox checkBox = new PDCheckbox(form);
+ PDCheckBox checkBox = new PDCheckBox(form);
// test that there are no nulls returned for an empty field
// only specific methods are tested here