You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/11 15:06:20 UTC
[GitHub] graceguo-supercat closed pull request #5849: [bugfix] fix rows not
showing on welcome page (retry)
graceguo-supercat closed pull request #5849: [bugfix] fix rows not showing on welcome page (retry)
URL: https://github.com/apache/incubator-superset/pull/5849
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/package.json b/superset/assets/package.json
index d93106e430..3cb7fe9999 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -114,7 +114,7 @@
"react-syntax-highlighter": "^7.0.4",
"react-virtualized": "9.19.1",
"react-virtualized-select": "^3.1.3",
- "reactable": "1.0.2",
+ "reactable": "^1.1.0",
"redux": "^3.5.2",
"redux-localstorage": "^0.4.1",
"redux-thunk": "^2.1.0",
diff --git a/superset/assets/src/welcome/App.jsx b/superset/assets/src/welcome/App.jsx
index 1591b521dd..35283453e8 100644
--- a/superset/assets/src/welcome/App.jsx
+++ b/superset/assets/src/welcome/App.jsx
@@ -1,4 +1,3 @@
-/* eslint no-unused-vars: 0 */
import React from 'react';
import { hot } from 'react-hot-loader';
import { appSetup } from '../common';
diff --git a/superset/assets/src/welcome/DashboardTable.jsx b/superset/assets/src/welcome/DashboardTable.jsx
index 6b6b71029f..0f4c744151 100644
--- a/superset/assets/src/welcome/DashboardTable.jsx
+++ b/superset/assets/src/welcome/DashboardTable.jsx
@@ -1,9 +1,6 @@
-/* eslint no-unused-vars: 0 */
import React from 'react';
-import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
-import { Table, Tr, Td, Thead, Th, unsafe } from 'reactable';
-
+import { Table, Tr, Td, unsafe } from 'reactable';
import Loading from '../components/Loading';
import '../../stylesheets/reactable-pagination.css';
@@ -64,4 +61,5 @@ export default class DashboardTable extends React.PureComponent {
return <Loading />;
}
}
+
DashboardTable.propTypes = propTypes;
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index 243371e7ae..4f0e6fce0b 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -10282,9 +10282,9 @@ react@^16.4.1:
prop-types "^15.6.2"
schedule "^0.3.0"
-reactable@1.0.2:
- version "1.0.2"
- resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.0.2.tgz#67a579fee3af68b991b5f04df921a4a40ece0b72"
+reactable@^1.1.0:
+ version "1.1.0"
+ resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.1.0.tgz#2f84bb8b3808df8ac64694b539be416438db8498"
reactcss@^1.2.0:
version "1.2.3"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org