[GitHub] [daffodil-vscode] jw3 commented on pull request #73: Bump extension daffodilVersion to 3.2.1

[GitBox <gi...@apache.org>]

jw3 commented on pull request #73:
URL: https://github.com/apache/daffodil-vscode/pull/73#issuecomment-1017072065


   > sbt compile fails with errors about java.nio.file.Path.of not being valid
   
   Sounds like the wrong JDK, ensure it is 11.
   
   > I am having trouble testing the extension with Daffodil 3.2.1 because one of our Scala files imports org.apache.daffodil.debugger.Debugger but an exception is thrown that it can't be found
   
   This classpath issue is coming from the [sbt native packager bash template](https://github.com/apache/daffodil-vscode/blob/main/server/core/src/templates/bash-template#L369) which has the classpath hard coded to the 3.1.0 version.  That approach needs improved.  Seems to me there is a way to inject sections rather than specifying the full template.
   
   > merged in commit 8cdefdd
   
   Yeah, looks like I missed updating the version in the other location in that commit.  Instead of just updating it again in this PR it should be fixed to prevent future issues by centralizing to a single location.
   
   The package json seems like the logical place for that, where it can then be read out in the typescript and sbt dependents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org