You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/28 06:30:48 UTC

[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #588: [IOTDB-323] Batch insert in session

JackieTien97 commented on a change in pull request #588:  [IOTDB-323] Batch insert in session
URL: https://github.com/apache/incubator-iotdb/pull/588#discussion_r351609317
 
 

 ##########
 File path: session/src/main/java/org/apache/iotdb/session/Session.java
 ##########
 @@ -154,7 +167,12 @@ public synchronized void close() throws IoTDBSessionException {
     }
   }
 
-  public synchronized TSExecuteBatchStatementResp insertBatch(RowBatch rowBatch)
 
 Review comment:
   Why we no longer need the synchronized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services