You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Diego Santesteban <di...@ca.ibm.com> on 2017/05/08 16:31:29 UTC
Review Request 59053: Review for AMBARI-20946
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20946
https://issues.apache.org/jira/browse/AMBARI-20946
Repository: ambari
Description
-------
I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
Diffs
-----
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
Diff: https://reviews.apache.org/r/59053/diff/1/
Testing
-------
I created a new test case and successfully ran all tests with 'mvn clean test'.
I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
Thanks,
Diego Santesteban
Re: Review Request 59053: Review for AMBARI-20946
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174187
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py
Line 168 (original), 168 (patched)
<https://reviews.apache.org/r/59053/#comment247309>
Should add a comment in here saying the archive will be created if it doesn't exist even if there is a hash file with equal to the directories hash.
- Tim Thorpe
On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 4:31 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
>
> I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
> ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
>
>
> Diff: https://reviews.apache.org/r/59053/diff/1/
>
>
> Testing
> -------
>
> I created a new test case and successfully ran all tests with 'mvn clean test'.
>
> I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
>
>
> Thanks,
>
> Diego Santesteban
>
>
Re: Review Request 59053: Review for AMBARI-20946
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174203
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 4:31 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
>
> I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
> ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
>
>
> Diff: https://reviews.apache.org/r/59053/diff/1/
>
>
> Testing
> -------
>
> I created a new test case and successfully ran all tests with 'mvn clean test'.
>
> I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
>
>
> Thanks,
>
> Diego Santesteban
>
>
Re: Review Request 59053: Review for AMBARI-20946
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174188
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On May 8, 2017, 4:31 p.m., Diego Santesteban wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 4:31 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
>
> I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
> ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
>
>
> Diff: https://reviews.apache.org/r/59053/diff/1/
>
>
> Testing
> -------
>
> I created a new test case and successfully ran all tests with 'mvn clean test'.
>
> I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
>
>
> Thanks,
>
> Diego Santesteban
>
>
Re: Review Request 59053: Review for AMBARI-20946
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174218
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On May 8, 2017, 7:09 p.m., Diego Santesteban wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59053/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 7:09 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20946
> https://issues.apache.org/jira/browse/AMBARI-20946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
>
> I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
> ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
>
>
> Diff: https://reviews.apache.org/r/59053/diff/2/
>
>
> Testing
> -------
>
> I created a new test case and successfully ran all tests with 'mvn clean test'.
>
> I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
>
>
> Thanks,
>
> Diego Santesteban
>
>
Re: Review Request 59053: Review for AMBARI-20946
Posted by Diego Santesteban <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/
-----------------------------------------------------------
(Updated May 8, 2017, 7:09 p.m.)
Review request for Ambari and Tim Thorpe.
Changes
-------
Updated the comment that Tim mentioned.
Bugs: AMBARI-20946
https://issues.apache.org/jira/browse/AMBARI-20946
Repository: ambari
Description
-------
I added an extra case in resourceFilesKeeper.py to recreate the archive.zip file if it doesn't exist, even when the saved and current directory hashes are matching.
I added one new test case to make sure this case is working, and modified one existing test case to make it specific for the other case (where the archive.zip file does exist and the hashes match).
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py dba6833924
ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3
Diff: https://reviews.apache.org/r/59053/diff/2/
Changes: https://reviews.apache.org/r/59053/diff/1-2/
Testing
-------
I created a new test case and successfully ran all tests with 'mvn clean test'.
I also applied this change to an existing cluster to ensure that it does fix the issue in a real usage case.
Thanks,
Diego Santesteban