You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/25 00:40:29 UTC
Review Request 17338: Fixed a bug that causes incorrect log output when
there is no master detected.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17338/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
- Without stringify the conditional operator converts “None” to an empty UPID and outputs @0.0.0.0:0
- Maybe it's worthwhile to make UPID's single-argument constructors explicit?
Diffs
-----
src/master/master.cpp c7d9186b9c22fb40b05aa6d5bc6f2d38fb7f73ea
src/slave/slave.cpp 2d21e16a04d8f2419d8dee6c18664f1024bb8e73
Diff: https://reviews.apache.org/r/17338/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request 17338: Fixed a bug that causes incorrect log output when
there is no master detected.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17338/#review32766
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 24, 2014, 11:40 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17338/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 11:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Without stringify the conditional operator converts “None” to an empty UPID and outputs @0.0.0.0:0
> - Maybe it's worthwhile to make UPID's single-argument constructors explicit?
>
>
> Diffs
> -----
>
> src/master/master.cpp c7d9186b9c22fb40b05aa6d5bc6f2d38fb7f73ea
> src/slave/slave.cpp 2d21e16a04d8f2419d8dee6c18664f1024bb8e73
>
> Diff: https://reviews.apache.org/r/17338/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 17338: Fixed a bug that causes incorrect log output when
there is no master detected.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17338/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 9:46 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Jie's
Repository: mesos-git
Description
-------
- Without stringify the conditional operator converts “None” to an empty UPID and outputs @0.0.0.0:0
- Maybe it's worthwhile to make UPID's single-argument constructors explicit?
Diffs (updated)
-----
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4
Diff: https://reviews.apache.org/r/17338/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request 17338: Fixed a bug that causes incorrect log output when
there is no master detected.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17338/#review32762
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/17338/#comment61734>
#include <stout/stringify.hpp>
- Jie Yu
On Jan. 24, 2014, 11:40 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17338/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 11:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Without stringify the conditional operator converts “None” to an empty UPID and outputs @0.0.0.0:0
> - Maybe it's worthwhile to make UPID's single-argument constructors explicit?
>
>
> Diffs
> -----
>
> src/master/master.cpp c7d9186b9c22fb40b05aa6d5bc6f2d38fb7f73ea
> src/slave/slave.cpp 2d21e16a04d8f2419d8dee6c18664f1024bb8e73
>
> Diff: https://reviews.apache.org/r/17338/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>