You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/05/09 10:08:14 UTC

[GitHub] [cordova-docs] jofravelo opened a new pull request, #1246: Correct "plugins" section syntaxe in package.json

jofravelo opened a new pull request, #1246:
URL: https://github.com/apache/cordova-docs/pull/1246

   ### Platforms affected
   Android, iOS
   
   ### Motivation and Context
   Having hasd to use package.json to declare plugins in my project, I noticed that the array form was wrongly communicating the names of the plugins as numbers, so noticed that cordova is specting it to be an object/map and not an array.
   
   ### Description
   Only changed the list of plugins from an array to an object.
   
   ### Testing
   - Execute the prepare step as usual declaring plugins, only in package.json, as an array. It should fail with a message like the following:
     -   `Failed to restore plugin "0". You might need to try adding it again. Error: CordovaError: Cannot find plugin.xml for plugin "0". Please try adding it again.
   Discovered plugin "2". Adding it to the project`
   - Then, change it to an object. It should work now.
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [X ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] breautek merged pull request #1246: Correct "plugins" section syntaxe in package.json

Posted by GitBox <gi...@apache.org>.
breautek merged PR #1246:
URL: https://github.com/apache/cordova-docs/pull/1246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] breautek commented on pull request #1246: Correct "plugins" section syntaxe in package.json

Posted by GitBox <gi...@apache.org>.
breautek commented on PR #1246:
URL: https://github.com/apache/cordova-docs/pull/1246#issuecomment-1186086458

   Thank you for contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org