You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/08/27 21:08:45 UTC

[GitHub] [storm] krichter722 commented on a change in pull request #3115: STORM-3490: Add checkstyle rule RedundantModifier

krichter722 commented on a change in pull request #3115: STORM-3490: Add checkstyle rule RedundantModifier
URL: https://github.com/apache/storm/pull/3115#discussion_r318297846
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidationUtils.java
 ##########
 @@ -143,15 +143,15 @@ public void validateField(String pd, String name, Object field)
     /**
      * Declares methods for validating configuration values.
      */
-    public static interface FieldValidator {
+    interface FieldValidator {
 
 Review comment:
   Correct, only `static` is redundant here, I corrected that in an added commit. Thanks for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services