You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/23 01:49:00 UTC
Review Request 46594: Added test for isolator cleanup before prepare.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46594/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
Repository: mesos
Description
-------
Added test for isolator cleanup before prepare.
Diffs
-----
src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce
Diff: https://reviews.apache.org/r/46594/diff/
Testing
-------
make check
Verified that the test fails if we reverted the fix.
Thanks,
Gilbert Song
Re: Review Request 46594: Added test for isolator cleanup before
prepare.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46594/#review130242
-----------------------------------------------------------
Bad patch!
Reviews applied: [46594, 46593, 46577, 46576]
Failed command: ./support/apply-review.sh -n -r 46576
Error:
2016-04-23 02:47:04 URL:https://reviews.apache.org/r/46576/diff/raw/ [1376/1376] -> "46576.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:892
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12679/console
- Mesos ReviewBot
On April 22, 2016, 11:49 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46594/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 11:49 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for isolator cleanup before prepare.
>
>
> Diffs
> -----
>
> src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce
>
> Diff: https://reviews.apache.org/r/46594/diff/
>
>
> Testing
> -------
>
> make check
>
> Verified that the test fails if we reverted the fix.
>
>
> Thanks,
>
> Gilbert Song
>
>