You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/09 11:46:10 UTC
[GitHub] [superset] EugeneTorap commented on a diff in pull request #22623: chore: skip puppeteer chromium download
EugeneTorap commented on code in PR #22623:
URL: https://github.com/apache/superset/pull/22623#discussion_r1064552326
##########
Dockerfile:
##########
@@ -23,6 +23,7 @@ FROM node:16-slim AS superset-node
ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
+ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
Review Comment:
Why do we need to add `Chromium` to the image?
What do we use `Puppeteer` for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org