You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/09 00:01:34 UTC
Review Request 42092: Add test for accept/decline offers and inverse
offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42092/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere.
Bugs: MESOS-4301
https://issues.apache.org/jira/browse/MESOS-4301
Repository: mesos
Description
-------
This tests `Call::ACCEPT` and `Call::DECLINE` that contain `OfferID` 's for both offers and inverse offers.
Diffs
-----
src/tests/master_maintenance_tests.cpp 2da6a2d4b786d9c5f64be8b5ab95f70ef3d98f92
Diff: https://reviews.apache.org/r/42092/diff/
Testing
-------
bin/mesos-tests.sh --gtest_filter="*MasterMaintenanceTest.OffersAndInverseOffers*" --verbose
This test currently fails with the following verbose logs:
```
I0108 14:54:43.211351 287354880 master.cpp:5360] Sending 1 offers to framework 568b7754-9b13-42ef-8054-0a1e55a2a5a4-0000 (default)
I0108 14:54:43.211797 287354880 master.cpp:5450] Sending 1 inverse offers to framework 568b7754-9b13-42ef-8054-0a1e55a2a5a4-0000 (default)
I0108 14:54:43.236057 285208576 http.cpp:315] HTTP POST for /master/api/v1/scheduler from 10.0.79.8:62572
W0108 14:54:43.236501 285208576 master.cpp:3104] ACCEPT call used invalid offers '[ 568b7754-9b13-42ef-8054-0a1e55a2a5a4-O3, 568b7754-9b13-42ef-8054-0a1e55a2a5a4-O4 ]': Offer 568b7754-9b13-42ef-8054-0a1e55a2a5a4-O4 is no longer valid
I0108 14:54:43.236636 285208576 master.cpp:4838] Sending status update TASK_LOST) for task e8b41312-82fa-4886-b119-782761e73dd6 of framework 568b7754-9b13-42ef-8054-0a1e55a2a5a4-0000 'Task launched with invalid offers: Offer 568b7754-9b13-42ef-8054-0a1e55a2a5a4-O4 is no longer valid'
../../src/tests/master_maintenance_tests.cpp:1567: Failure
Value of: event.get().update().status().state()
Actual: TASK_LOST
Expected: v1::TASK_RUNNING
Which is: TASK_RUNNING
```
Thanks,
Joseph Wu