You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scholarsmate (via GitHub)" <gi...@apache.org> on 2023/03/21 20:47:09 UTC
[GitHub] [daffodil-vscode] scholarsmate opened a new pull request, #510: Tab name to be the filepath of the file being edited
scholarsmate opened a new pull request, #510:
URL: https://github.com/apache/daffodil-vscode/pull/510
The panel object has a title property that is writable, but I don't see a way to do that and hover text. Here is what we get with this patch:
<img width="1526" alt="Screenshot 2023-03-21 at 4 43 47 PM" src="https://user-images.githubusercontent.com/2205472/226736206-bceae73d-4a05-4940-a0fa-2a16fac571bc.png">
I can name the tab the base name of the file, but that's not unique if we open say 2 different `package.json` files, then we have 2 tabs named the same thing.
Fixes #507.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #510: Tab name to be the filepath of the file being edited
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#discussion_r1144073985
##########
src/omega_edit/client.ts:
##########
@@ -142,8 +142,7 @@ export function activate(ctx: vscode.ExtensionContext) {
'extension.data.edit',
async (
startServ: boolean = true,
- port: number | undefined = undefined,
- fileToEdit: string = ''
Review Comment:
You will need to revert all these changes that deal with `fileToEdit`.
The code involving `fileToEdit` is essential for the API to function properly for the tests. With this change during the tests when the data editor is initially opened it will prompt to select a file which is not the desired behavior during testing. The test still currently passes since it just checks the webview is opened, which it is behind the file picking prompt. In future tests for the data editor we will want to use the content that is inside of the data editor. To do this we need to be able to specify the file we wish to edit so that the editor will contain content and not get stuck on a file prompt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #510: Tab name to be the filepath of the file being edited
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#discussion_r1144736083
##########
src/omega_edit/client.ts:
##########
@@ -142,8 +142,7 @@ export function activate(ctx: vscode.ExtensionContext) {
'extension.data.edit',
async (
startServ: boolean = true,
- port: number | undefined = undefined,
- fileToEdit: string = ''
Review Comment:
I'm not happy with having this testing cruft in the shipped project. I've reverted it _temporarily_ and will revisit later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #510: Tab name to be the filepath of the file being edited
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#issuecomment-1478564838
It would be great if we can figure out how to make the hover text use the full path name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate merged pull request #510: Tab name to be the filepath of the file being edited
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate merged PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #510: Tab name to be the filepath of the file being edited
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#issuecomment-1479792919
@arosien, will you please review this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org