You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by MariaBukharina <gi...@git.apache.org> on 2014/10/09 16:30:36 UTC
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
GitHub user MariaBukharina opened a pull request:
https://github.com/apache/cordova-coho/pull/52
[CB-7744] Add support for git-depth flag to coho clone
Add support for git-depth flag to coho clone to be able to check out only latest version and reduce check out time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho CB-7744
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 7dd276bffc462e8706460dc03021f53d9ba0082f
Author: maria.bukharina <ma...@akvelon.com>
Date: 2014-10-09T14:23:58Z
[CB-7744] Add support for git-depth flag to coho clone
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-coho/pull/52#issuecomment-58696669
@agrieve, @purplecabbage thx for looking on this!
I've asked @MariaBukharina to send PR one more time w/o 'd' alias for '--depth' arg since we use -d for debug in other places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-coho pull request: [CB-7744] Add support for
git-depth fla...
Posted by Andrew Grieve <ag...@chromium.org>.
Good call.
On Fri, Oct 10, 2014 at 2:14 PM, purplecabbage <gi...@git.apache.org> wrote:
> Github user purplecabbage commented on the pull request:
>
> https://github.com/apache/cordova-coho/pull/52#issuecomment-58695256
>
> We should stop closing issues from other repositories, since @asfgit
> closing it does not give us any more info.
> Looking at cordova-coho and elsewhere, I still see no mention of 52,
> so this one is a mystery.
> Here is a 'multi repo close issues' commit message:
> ```
> close apache/cordova-lib#94
> close #39
> close apache/cordova-android#120
> close apache/cordova-android#123
> ```
> At least a practice of only closing from the repo with the pull
> request would make this a bit easier to track down. Magic is powerful, use
> it wisely.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-coho/pull/52#issuecomment-58695256
We should stop closing issues from other repositories, since @asfgit closing it does not give us any more info.
Looking at cordova-coho and elsewhere, I still see no mention of 52, so this one is a mystery.
Here is a 'multi repo close issues' commit message:
```
close apache/cordova-lib#94
close #39
close apache/cordova-android#120
close apache/cordova-android#123
```
At least a practice of only closing from the repo with the pull request would make this a bit easier to track down. Magic is powerful, use it wisely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/52#issuecomment-58642817
I don't see any commit logs that tell it close it, and I don't see it merged either.
Change LGTM as well. Maybe just pull it in now even though it's closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: [CB-7744] Add support for git-depth fla...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-coho/pull/52#issuecomment-58634089
Does anyone know why this PR was closed w/o any comment? I personally think that this option is very valuable, for example to significantly speed up Medic which uses coho to check out platforms and plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org