You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/03/29 06:16:19 UTC

[PR] WW-5621 Harden XML parsers against Entity Expansion (Billion Laughs) attacks [S6] [struts]

lukaszlenart opened a new pull request, #1643:
URL: https://github.com/apache/struts/pull/1643

   ## Summary
   
   Backport of #1642 from Struts 7 to Struts 6.
   
   - Enable `FEATURE_SECURE_PROCESSING` in `DomHelper` and Tiles `DigesterDefinitionsReader`
   - Remove unused `parseStringAsXML` feature from `StringAdapter` to eliminate theoretical attack surface
   - Deprecate `getParseStringAsXML()` / `setParseStringAsXML()` for future removal
   - Add Billion Laughs protection tests for both XML parsers
   
   ## Test plan
   
   - [x] `mvn test -DskipAssembly -pl core -Dtest=DomHelperTest` — 4 tests pass
   - [x] `mvn test -DskipAssembly -pl plugins/tiles -Dtest="TestDigesterDefinitionsReader#testBillionLaughsProtection"` — 1 test passes
   - [x] `mvn test -DskipAssembly -pl plugins/xslt` — builds successfully
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] WW-5621 Harden XML parsers against Entity Expansion (Billion Laughs) attacks [S6] [struts]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #1643:
URL: https://github.com/apache/struts/pull/1643#issuecomment-4149546974

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1643) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [25 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1643&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [43.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1643&metric=new_coverage&view=list) (required ≥ 80%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [3.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1643&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1643) (required ≥ A)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1643) (required ≥ A)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1643)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] WW-5621 Harden XML parsers against Entity Expansion (Billion Laughs) attacks [S6] [struts]

Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.

lukaszlenart merged PR #1643:
URL: https://github.com/apache/struts/pull/1643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org