You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/02/11 15:37:07 UTC
[GitHub] couchdb-couch pull request: Propagate db delete event to changes c...
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/139
Propagate db delete event to changes callback
Not propagating the `delete` event to the changes callback causes
db to stay open when it is deleted in the presence of `continuous`
requests to `_changes` feed. This in its turn causes `couch_file` to stay
open until the connection is closed by the client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch should_end_changes_when_db_deleted
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit bbe1728b89e54f757a5efc37ac40c4d2cce9b436
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2016-02-11T00:26:22Z
Propagate db delete event to changes callback
Not propagating the `delete` event to the changes callback causes
db to stay open when it is deleted in the presence of `continuous`
requests to _changes feed. This in its turn causes couch_file to stay
open until the connection is closed by the client.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Propagate db delete event to changes c...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/139#issuecomment-184772524
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Propagate db delete event to changes c...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/139#issuecomment-182985508
I looked at that test failure and it appears unrelated, but we might also want to verify that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Propagate db delete event to changes c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Propagate db delete event to changes c...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/139#issuecomment-182985320
Ahhh, took me two readings of your commit message before I put the whole thing together. I kept trying to figure out how we introduced the bug during the merge and got confused by the work on view changes. Rereading your commit message it appears to not be a new bug, just one we hadn't noticed yet.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---