You are viewing a plain text version of this content. The canonical link for it is here.
Posted to photark-dev@incubator.apache.org by "nick choi (JIRA)" <ji...@apache.org> on 2010/02/25 06:48:28 UTC
[jira] Created: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Repeatedly call populateSelect method in upload.html
----------------------------------------------------
Key: PHOTARK-21
URL: https://issues.apache.org/jira/browse/PHOTARK-21
Project: PhotArk
Issue Type: Bug
Components: PhotArk Admin Services
Environment: Ubuntu 9.10, Firefox 3.5.8
Reporter: nick choi
Priority: Minor
After rendering /photark/admin/upload.html,
repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
because as soon as rendering this page, focus of page is at select tag(selectAlbum).
That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-21) Repeatedly call populateSelect
method in upload.html
Posted by "Nick Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838673#action_12838673 ]
Nick Choi commented on PHOTARK-21:
----------------------------------
Here is improved patch.
Now I try to fix another problem that a new album isn't displayed after creating a new album.
I remove onfocus and loadSelected variable.
I add onload="populateSelected()" in body tag and createAlbum() function.
But, this soultion is that we have to call populateSelected() when Creating, Updating, Deleting album.
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: Nick Choi
> Priority: Minor
> Attachments: upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Posted by "Nick Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Choi updated PHOTARK-21:
-----------------------------
Attachment: upload.html.improve.patch
Here is improved patch.
Now I try to fix another problem that a new album isn't displayed after creating a new album.
I remove onfocus and loadSelected variable.
I add onload="populateSelected()" in body tag and createAlbum() function.
But, we have to call "populateSelected()" when Creating, Updating, Deleting album.
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: Nick Choi
> Priority: Minor
> Attachments: upload.html.improve.patch, upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-21) Repeatedly call populateSelect
method in upload.html
Posted by "Avdhesh Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838238#action_12838238 ]
Avdhesh Yadav commented on PHOTARK-21:
--------------------------------------
I have Tested it on both ff and chrome and this patch fix the problem..
We can commit this patch..Thanks
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: nick choi
> Priority: Minor
> Attachments: upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Posted by "Nick Choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Choi updated PHOTARK-21:
-----------------------------
Comment: was deleted
(was: Here is improved patch.
Now I try to fix another problem that a new album isn't displayed after creating a new album.
I remove onfocus and loadSelected variable.
I add onload="populateSelected()" in body tag and createAlbum() function.
But, this soultion is that we have to call populateSelected() when Creating, Updating, Deleting album.)
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: Nick Choi
> Priority: Minor
> Attachments: upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Posted by "nick choi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nick choi updated PHOTARK-21:
-----------------------------
Attachment: upload.html.patch
I made simple patch to solve this problem.
I set a boolean flag(loadSelected) after calling populateSelect().
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: nick choi
> Priority: Minor
> Attachments: upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-21) Repeatedly call populateSelect
method in upload.html
Posted by "Avdhesh Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838244#action_12838244 ]
Avdhesh Yadav commented on PHOTARK-21:
--------------------------------------
Patch applied under svn #916180. Thanks.
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: nick choi
> Priority: Minor
> Attachments: upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende reassigned PHOTARK-21:
--------------------------------------
Assignee: Luciano Resende
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: Nick Choi
> Assignee: Luciano Resende
> Priority: Minor
> Attachments: upload.html.improve.patch, upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PHOTARK-21) Repeatedly call populateSelect method
in upload.html
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende resolved PHOTARK-21.
------------------------------------
Resolution: Fixed
Fix Version/s: PhotArk M2
Thanks for the patch Nick. I have taken a slight different approach to fix this issue (see svn revision 917101) where I changed the admin page to only call populateSelect when the page is first loaded, and then we dynamically add new albums to the list of available albums when they get created without having to retrieve the full list again from the server.
> Repeatedly call populateSelect method in upload.html
> ----------------------------------------------------
>
> Key: PHOTARK-21
> URL: https://issues.apache.org/jira/browse/PHOTARK-21
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk Admin Services
> Environment: Ubuntu 9.10, Firefox 3.5.8
> Reporter: Nick Choi
> Assignee: Luciano Resende
> Priority: Minor
> Fix For: PhotArk M2
>
> Attachments: upload.html.improve.patch, upload.html.patch
>
>
> After rendering /photark/admin/upload.html,
> repeatedly call populateSelect method by onfocus="populateSelect()" on firefox
> because as soon as rendering this page, focus of page is at select tag(selectAlbum).
> That affects albumname is null when uploading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.