You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiacai2050 (via GitHub)" <gi...@apache.org> on 2023/06/02 03:11:47 UTC

[GitHub] [arrow-datafusion] jiacai2050 opened a new pull request, #6523: Page filter

jiacai2050 opened a new pull request, #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6523: make page filter public

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523#issuecomment-1582347553

   THanks @jiacai2050 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6523: WIP: make page filter public

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523#issuecomment-1577342821

   I believe if you merge up to latest main branch the clippy failure has been resolved. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jiacai2050 commented on pull request #6523: WIP: make page filter public

Posted by "jiacai2050 (via GitHub)" <gi...@apache.org>.
jiacai2050 commented on PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523#issuecomment-1575931374

   @alamb Thanks, I'm still testing this changeset in CeresDB, I will add more context once I'm done.
   
   > Also if you want to use this API long term I suggest we implement an end to end test (maybe in datafusion/core/tests/parquet somewhere) for it so that it isn't broken accidentally in some future refactor
   
   Agreed!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6523: make page filter public

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523#issuecomment-1580427283

   It appears that `cargo doc` wants documentation for public structures, so the structures that are now `pub` need documentation to pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6523: WIP: make page filter public

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523#issuecomment-1577338188

   This PR still says "WIP" in the title so I am not sure if you think it is ready to merge @jiacai2050  -- or if you plan to work on an end to end test before doing so?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6523: make page filter public

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6523:
URL: https://github.com/apache/arrow-datafusion/pull/6523


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org