You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/27 08:50:27 UTC
[GitHub] [dolphinscheduler] hiSandog opened a new pull request, #12165: [fix][docker] Docker-deploy added the common.properties.
hiSandog opened a new pull request, #12165:
URL: https://github.com/apache/dolphinscheduler/pull/12165
Now with Docker publishing, common.properties cannot be configured.
This problem should be solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12165: [fix][docker] Docker-deploy added the common.properties.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12165:
URL: https://github.com/apache/dolphinscheduler/pull/12165#issuecomment-1472932705
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed pull request #12165: [fix][docker] Docker-deploy added the common.properties.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12165: [fix][docker] Docker-deploy added the common.properties.
URL: https://github.com/apache/dolphinscheduler/pull/12165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12165: [fix][docker] Docker-deploy added the common.properties.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12165:
URL: https://github.com/apache/dolphinscheduler/pull/12165#issuecomment-1705789364
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12165: [fix][docker] Docker-deploy added the common.properties.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #12165:
URL: https://github.com/apache/dolphinscheduler/pull/12165#discussion_r981399345
##########
deploy/docker/common.properties:
##########
@@ -0,0 +1,124 @@
+#
Review Comment:
> Can we just reuse this file instead of duplicating it, we have to maintain several `common.properties` files...
>
> https://github.com/apache/dolphinscheduler/blob/6466cc7c41bc32596499b023ed483387cb32d02a/dolphinscheduler-common/src/main/resources/common.properties#L17
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #12165: [fix][docker] Docker-deploy added the common.properties.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #12165:
URL: https://github.com/apache/dolphinscheduler/pull/12165#discussion_r981165197
##########
deploy/docker/common.properties:
##########
@@ -0,0 +1,124 @@
+#
Review Comment:
Can we just reuse this file instead of duplicating it, we have to maintain several `common.properties` files... https://github.com/apache/dolphinscheduler/blob/6466cc7c41bc32596499b023ed483387cb32d02a/dolphinscheduler-common/src/main/resources/common.properties#L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org