You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "yangshangqing95 (via GitHub)" <gi...@apache.org> on 2026/10/18 04:55:38 UTC

[PR] [flink] Report pending finished tiering tables on enumerator shutdown [fluss]

yangshangqing95 opened a new pull request, #4703:
URL: https://github.com/apache/fluss/pull/4703

   ### Purpose
   
   Fix #4702
   
   `TieringSourceEnumerator` may lose completed tiering reports if it is closed before a scheduled asynchronous heartbeat executes.
   
   Previously, `close()` only reported failed tables, leaving pending entries in `finishedTables` unreported. This could leave the Coordinator treating an already completed table as still being tiered, delaying subsequent tiering rounds.
   
   ### Brief change log
   
   - Report both pending finished and failed tables through the existing heartbeat mechanism during enumerator shutdown.
   - Ensure heartbeat failures do not prevent resource cleanup.
   
   ### Tests
   
   Added two regression tests in `TieringSourceEnumeratorTest`:
   
   - `testCloseReportsFinishedAndRunningTablesBeforePendingHeartbeat`: Verifies that finished and running tables are correctly reported when the enumerator closes before the pending heartbeat executes.
   - `testCloseReleasesRpcClientWhenHeartbeatFails`: Verifies that the RPC client is still closed when the shutdown heartbeat fails.
   
   ### API and Format
   
   No changes.
   
   ### Documentation
   
   Not applicable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [flink] Report pending finished tiering tables on enumerator shutdown [fluss]

Posted by "yangshangqing95 (via GitHub)" <gi...@apache.org>.
yangshangqing95 commented on PR #4703:
URL: https://github.com/apache/fluss/pull/4703#issuecomment-6366944290

   Thanks @polyzos !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [flink] Report pending finished tiering tables on enumerator shutdown [fluss]

Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos commented on PR #4703:
URL: https://github.com/apache/fluss/pull/4703#issuecomment-6358215137

   Thanks @yangshangqing95. It turns out #4663 was merged this morning and fixes the same problem the same way. Seems like there were duplicate tickets, but appreciate tracking this down!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [flink] Report pending finished tiering tables on enumerator shutdown [fluss]

Posted by "polyzos (via GitHub)" <gi...@apache.org>.
polyzos closed pull request #4703: [flink] Report pending finished tiering tables on enumerator shutdown
URL: https://github.com/apache/fluss/pull/4703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org