You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/12/12 22:15:27 UTC

[GitHub] spark pull request #19956: [SPARK-22764][core] Fix flakiness in SparkContext...

GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/19956

    [SPARK-22764][core] Fix flakiness in SparkContextSuite.

    Use a semaphore to synchronize the tasks with the listener code
    that is trying to cancel the job or stage, so that the listener
    won't try to cancel a job or stage that has already finished.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-22764

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19956
    
----
commit 8b9d01e37dd22167ac9c7ca53ecb153ee5f274da
Author: Marcelo Vanzin <va...@cloudera.com>
Date:   2017-12-12T22:13:38Z

    [SPARK-22764][core] Fix flakiness in SparkContextSuite.
    
    Use a semaphore to synchronize the tasks with the listener code
    that is trying to cancel the job or stage, so that the listener
    won't try to cancel a job or stage that has already finished.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    **[Test build #84799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84799/testReport)** for PR 19956 at commit [`8b9d01e`](https://github.com/apache/spark/commit/8b9d01e37dd22167ac9c7ca53ecb153ee5f274da).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84799/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by squito <gi...@git.apache.org>.
Github user squito commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    **[Test build #84799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84799/testReport)** for PR 19956 at commit [`8b9d01e`](https://github.com/apache/spark/commit/8b9d01e37dd22167ac9c7ca53ecb153ee5f274da).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19956: [SPARK-22764][core] Fix flakiness in SparkContext...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19956


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19956: [SPARK-22764][core] Fix flakiness in SparkContextSuite.

Posted by squito <gi...@git.apache.org>.
Github user squito commented on the issue:

    https://github.com/apache/spark/pull/19956
  
    lgtm


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org