You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/11/26 17:55:57 UTC

[GitHub] [streampipes] dominikriemer opened a new issue, #793: Empty string as API token name

dominikriemer opened a new issue, #793:
URL: https://github.com/apache/streampipes/issues/793

   Currently, StreamPipes allows to have an empty string as name when generating an API token in the UI. We should add a validator here.
   
   Imported from Jira [STREAMPIPES-645](https://issues.apache.org/jira/browse/STREAMPIPES-645). Original Jira may contain additional context.
   Reported by: bossenti.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
bossenti commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1368195121

   Okay, then I think the easiest way is to follow this workaround:
   1. go to `/installer/cli/
   2. create a file named `.spenv`
   3. go to `installer/cli/environments/` and copy the content of the file `ui` into `.spenv`
   
   This finally does the same as the script that is not working on your machine. Let me know if that works for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1367955959

   > Hm thats really strange, both have always worked on my Windows 10 machine 🤔 
   > 
   > Are you able to run usual terminal commands in both of them?
   
   Yes, I can run usual terminal commands


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
bossenti commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1377538078

   Looks great 👍 
   The default user is the following:
   
   - name admin@streampipes.apache.org
   - password: admin
   
   You can change that once you are logged in if you want or create additional users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] dominikriemer commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
dominikriemer commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366522341

   Ok, Git bash should also work without problems. If WSL doesn't work, we can further investigate why the script doesn't work in your environment!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
bossenti commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1367238164

   Hm thats really strange, both have always worked on my Windows 10 machine 🤔 
   Are you able to run usual terminal commands in both of them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366129619

   By bash shell I meant Git bash. So, I'll try running with WSL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1367196641

   Hey @dominikriemer Unfortunately with GitBash, I'm facing the same issue as previously I have mentioned. Coming to WSL, It takes forever to open the project. The terminal is just blank and does not not load up.
   
   ![image](https://user-images.githubusercontent.com/56036364/209933842-ec7a40f8-970e-4714-9ff3-89033c2eede1.png)
   
   Can you suggest anything else? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] dominikriemer commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
dominikriemer commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366096316

   Hi @aamirxshaikh, which OS are using? 
   There shouldn't be a `cp` error when setting the environment - the `env --set` command should only create a new file called `.spenv` which includes all services defined for the environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Empty string as API token name (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1410801291

   Hi @aamirxshaikh,
   I couldn't find a validator in the code, but here is a tutorial on typed reactive forms [1].
   It also includes a regex validator. Since you are new to Anular, I would recommend trying the tutorial first.
   It is quite short and provides a good introduction.
   
   [1] https://www.syncfusion.com/blogs/post/strictly-typed-reactive-forms-in-angular.aspx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] bossenti commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
bossenti commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1364690594

   great to hear!
   First of all you need to setup StreamPipes locally in that way that you can develop the UI. Have a look at this [documentation](https://cwiki.apache.org/confluence/display/STREAMPIPES/UI).
   
   The gif below demonstrates the described issue:
   ![missing-api-token-name](https://user-images.githubusercontent.com/50115603/209471829-6297ee1a-668f-45fd-8786-cc4e9c6233cc.gif)
   
   
   Empty names for API tokens should be avoided, therefore we need a validator here.
   The corresponding Angular component can be found [here](https://github.com/apache/streampipes/tree/c0c2a6e9862fcce6150340aafb86b1d66c08ff3c/ui/src/app/profile/components/token).
   
   Hopefully, this provides you with enough information to start. Otherwise, just let me know.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366102708

   Hey @dominikriemer I'm using windows 11 (bash shell), 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirshaikh7 commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirshaikh7 commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1364653437

   Hey, @bossenti I'm interested in contributing to this issue. How can I get started with it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] dominikriemer commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
dominikriemer commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366117711

   I think the CLI is a unix bash script and doesn't work with the Windows bash. Under Windows 11, you can use e.g. Git bash or WSL to run the CLI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1377377175

   Hey, @bossenti Thanks for providing the guide. It seems that the issue was because of the whitespace in my parent directory. I'm now able to run it locally. I'm currently going through API docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [streampipes] aamirxshaikh commented on issue #793: Empty string as API token name

Posted by GitBox <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1366008271

   Hey @bossenti I'm following the documentation to setup streampipes locally and I'm unable to configure streampipes for ui development.
   
   I have followed all the mentioned steps.
   
   On running
   
   `./streampipes env --set ui`
   
   I get 
   ```
   [INFO] Set environment to 'ui'
   cp: target 'source/streampipes/installer/cli/.spenv' is not a directory
   ```
   
   When starting streampipes backend
   
   `./streampipes up -d`
   
   I get
   
   `[ERROR] Environment missing. See 'streampipes env --help'`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Empty string as API token name (streampipes)

Posted by "aamirxshaikh (via GitHub)" <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1413613189

   Thanks @tenthe, I'll check it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Empty string as API token name (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe closed issue #793: Empty string as API token name
URL: https://github.com/apache/streampipes/issues/793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Empty string as API token name (streampipes)

Posted by "aamirxshaikh (via GitHub)" <gi...@apache.org>.
aamirxshaikh commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1406178747

   Hello @bossenti, I am trying to implement the validation for the input field as mentioned in the issue. I have tried it, but I'm having trouble getting it to work. I've read the documentation and tried various approaches, but I'm still stuck. Can you please point me to any relevant resources or similar code in the codebase that I can refer to for guidance? Also, could you let me know what the validation conditions are for this input field? I want to make sure I'm meeting all the requirements. I'd really appreciate it. Thank you in advance for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Empty string as API token name (streampipes)

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #793:
URL: https://github.com/apache/streampipes/issues/793#issuecomment-1409220069

   thanks for catching up on this @aamirxshaikh.
   Fom my perspective the token name should be longer than three characters and only consist of alphanumeric symbols including `-` and `_`.
   
   @dominikriemer @tenthe can you provide Aamir with a sample of our codebase where we use a validator? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org