You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/19 22:02:20 UTC

Review Request: Added some TODOs to duration.hpp and os.hpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10027/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

These are just TODOs that I don't want to lose track of. Needed the extra commit since they live in stout.


Diffs
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663 
  third_party/libprocess/third_party/stout/include/stout/os.hpp 905e783f837395dd8d3db16e487845c120ae8c91 

Diff: https://reviews.apache.org/r/10027/diff/


Testing
-------


Thanks,

Ben Mahler

Re: Review Request: Added some TODOs to duration.hpp and os.hpp.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10027/
-----------------------------------------------------------

(Updated March 20, 2013, 10:55 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Fixed the comment, no need for further reviews.


Description
-------

These are just TODOs that I don't want to lose track of. Needed the extra commit since they live in stout.


Diffs (updated)
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663 
  third_party/libprocess/third_party/stout/include/stout/os.hpp 905e783f837395dd8d3db16e487845c120ae8c91 

Diff: https://reviews.apache.org/r/10027/diff/


Testing
-------


Thanks,

Ben Mahler

Re: Review Request: Added some TODOs to duration.hpp and os.hpp.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10027/#review18163
-----------------------------------------------------------

Ship it!



third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/10027/#comment38316>

    s/compiler/linker/


- Benjamin Hindman


On March 19, 2013, 9:02 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10027/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 9:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> These are just TODOs that I don't want to lose track of. Needed the extra commit since they live in stout.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/duration.hpp ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp 905e783f837395dd8d3db16e487845c120ae8c91 
> 
> Diff: https://reviews.apache.org/r/10027/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>