[GitHub] [helix] narendly commented on issue #865: Add rerunFailingTestsCount config to surefire-plugin

[GitBox <gi...@apache.org>]

narendly commented on issue #865: Add rerunFailingTestsCount config to surefire-plugin
URL: https://github.com/apache/helix/pull/865#issuecomment-595573612
 
 
   This PR is ready to be merged, approved by @alirezazamani 
   
   
   It was observed that if build fails (if there is a test failure), then not all of the test goals are executed. There are currently two goals: default-test (single ZK) and multi-zk. If default-test has any test failures, we won't ever see multi-zk get executed, and this is a problem because we don't get to run the test suite in a multi-zk setup.
   
   This config change is a workaround for this - we allow failing tests to be retried up to 3 times to make them pass. If they still fail, we will consider them as flaky tests and have to fix them moving forward.
   
   This PR also address minor comments and fixes a test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org