[GitHub] [superset] craig-rueda commented on a diff in pull request #19537: chore: block unsafe functions

[GitBox <gi...@apache.org>]

craig-rueda commented on code in PR #19537:
URL: https://github.com/apache/superset/pull/19537#discussion_r843291395


##########
superset/databases/utils.py:
##########
@@ -113,6 +113,6 @@ def make_url_safe(raw_url: str) -> URL:
     :return:
     """
     try:
-        return make_url(raw_url.strip())
+        return make_url(raw_url.strip())  # noqa

Review Comment:
   This seems like a pretty easy way to get around this filter :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org