[jira] [Commented] (MAHOUT-1193) We may want a BlockSparseMatrix

["Saleem Ansari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700956#comment-13700956 ] 

Saleem Ansari commented on MAHOUT-1193:
---------------------------------------

Hi,

I was trying to understand how this Block Sparse Matrix is supposed to work. To begin with, I jave only tried to fix compile errors with respect to current trunk codebase.

BlockSparseMatrix.java

 * Resolved compilation errors against trunk.
 * Added unimplemented methods:  mergeUpdates(), getLookupCost(), getIteratorAdvanceCost(), isAddConstantTime()
 * Implemented methods: mergeUpdates(), getLookupCost(), getIteratorAdvanceCost(), isAddConstantTime()
 * Changed getColumn() -> viewColumn()
 * Changed getRow() -> viewRow()

BlockSparseMatrixTest.java

 * Use viewRow instead of getRow. The member 'test' is still private
 * Comment out private member

However many of the tests failed. I have put the test errors in a pastebin:

 * Test Errors: http://pastebin.com/0Za4AF3q

Is there any reference document or a paper against which this implementation was made?

Thanks,
Saleem
                
> We may want a BlockSparseMatrix
> -------------------------------
>
>                 Key: MAHOUT-1193
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1193
>             Project: Mahout
>          Issue Type: Bug
>            Reporter: Ted Dunning
>             Fix For: Backlog
>
>         Attachments: MAHOUT-1193-fix-compile-errors-tests-still-fail.patch, MAHOUT-1193.patch
>
>
> Here is an implementation.
> Is it good enough to commit?
> Is it useful?
> Is it redundant?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira