You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2018/11/12 17:04:17 UTC

[GitHub] tobias-istvan commented on issue #5: [AMBARI-24551] [Log Search UI] get rid of redundant requests after undoing or redoing several history steps

tobias-istvan commented on issue #5: [AMBARI-24551] [Log Search UI] get rid of redundant requests after undoing or redoing several history steps
URL: https://github.com/apache/ambari-logsearch/pull/5#issuecomment-437956593
 
 
   @aBabiichuk
   I completely refactored the history manager. The initial reason was to simplify the business logic around the history management, also make it more URL handling compatible since the history is connected to the linkable URL.
   
   I followed the previous approach which is use more action/effects/reducers over services in order to decouple the direct dependencies.
   
   The main reason of the redundant request was the wrong implementation of the `ControlValueAccessor` interface.
   
   I also added some UX improvements to indicate when a request is in progress in the background. There is a global notification and added some specific ones for log tables and graphs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services