You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/09/06 01:43:58 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #9617: [HUDI-1623] Solid completion time on timeline

danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1316590328


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/PreferWriterConflictResolutionStrategy.java:
##########
@@ -104,7 +104,7 @@ private Stream<HoodieInstant> getCandidateInstantsForTableServicesCommits(Hoodie
 
     // Merge and sort the instants and return.
     List<HoodieInstant> instantsToConsider = Stream.concat(completedCommitsStream, inflightIngestionCommitsStream)
-        .sorted(Comparator.comparing(o -> o.getStateTransitionTime()))
+        .sorted(Comparator.comparing(o -> o.getCompletionTime()))

Review Comment:
   Only completed instant has completion time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org