You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/23 07:54:06 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #7526: Kafka extra producer configuration enhancement

dmsolr commented on a change in pull request #7526:
URL: https://github.com/apache/skywalking/pull/7526#discussion_r693742884



##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -153,8 +153,8 @@ property key | Description | Default |
 `plugin.dubbo.provider_arguments_length_threshold`| When `plugin.dubbo.collect_provider_arguments` is `true`, Arguments of length from the front will to the OAP backend |`256`| 
 `plugin.kafka.bootstrap_servers`| A list of host/port pairs to use for establishing the initial connection to the Kafka cluster. | `localhost:9092`|
 `plugin.kafka.get_topic_timeout`| Timeout period of reading topics from the Kafka server, the unit is second. |`10`|
-`plugin.kafka.consumer_config`| Kafka producer configuration. ||

Review comment:
       Not, just forget to remove it from docs. This was originally reserved for `profile task` communication with OAP. But we discard this way. Agent communicate with OAP one way. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org