You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2007/12/19 00:02:00 UTC
[jira] Created: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
NameNode could delete wrong edits file when there is an error
-------------------------------------------------------------
Key: HADOOP-2460
URL: https://issues.apache.org/jira/browse/HADOOP-2460
Project: Hadoop
Issue Type: Bug
Components: dfs
Affects Versions: 0.15.0
Reporter: Raghu Angadi
Assignee: dhruba borthakur
Fix For: 0.15.2
On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553189 ]
Hadoop QA commented on HADOOP-2460:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371903/HADOOP-2460.patch
against trunk revision r605299.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/console
This message is automatically generated.
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-2460:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Raghu!
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-2460) NameNode could delete
wrong edits file when there is an error
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552939 ]
rangadi edited comment on HADOOP-2460 at 12/18/07 3:51 PM:
----------------------------------------------------------------
Suggested patch. I tested this patch with a forced failure.
was (Author: rangadi):
Suggested patch. I tested with patch with a forced failure.
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553325 ]
Hudson commented on HADOOP-2460:
--------------------------------
Integrated in Hadoop-Nightly #338 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/338/])
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-2460:
---------------------------------
Attachment: HADOOP-2460.patch
Suggested patch. I tested with patch with a forced failure.
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-2460:
-------------------------------------
Status: Patch Available (was: Open)
+1. Code looks good.
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2460) NameNode could delete wrong edits
file when there is an error
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553200 ]
Raghu Angadi commented on HADOOP-2460:
--------------------------------------
Test failure looks unrelated. The patch applies to both trunk and branch-0.15.
> NameNode could delete wrong edits file when there is an error
> -------------------------------------------------------------
>
> Key: HADOOP-2460
> URL: https://issues.apache.org/jira/browse/HADOOP-2460
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Raghu Angadi
> Assignee: dhruba borthakur
> Fix For: 0.15.2
>
> Attachments: HADOOP-2460.patch
>
>
> On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.
> Looks like it is caused by a bug in {{processIOError()}} in FSEditsLog.java. It removes the wrong directory since it passes in index into {{errorStreams}} rather than index into {{editStreams}} by mistake.
> This probably should go in 0.15.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.