You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:23:56 UTC
[GitHub] [incubator-annotator] Treora opened a new pull request #67:
Reorganise webpack-related files
Treora opened a new pull request #67: Reorganise webpack-related files
URL: https://github.com/apache/incubator-annotator/pull/67
- group all web(pack)-related files under /web
- add web:build and web:server scripts (yarn start = yarn run web:server)
- name build outputs 'bundle.js', make git ignore those
- make pages also work when opened without server (as file://…)
The main motivation was to be able to build the demo bundle so it can more easily be copied into the website repo — but I figured it’s good to organise these files a bit too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] tilgovi commented on a change in pull request
#67: Reorganise webpack-related files
Posted by GitBox <gi...@apache.org>.
tilgovi commented on a change in pull request #67: Reorganise webpack-related files
URL: https://github.com/apache/incubator-annotator/pull/67#discussion_r399738973
##########
File path: web/webpack.config.js
##########
@@ -43,7 +46,7 @@ module.exports = {
],
},
output: {
- filename: '[name].js',
- publicPath: '/',
+ path: path.resolve(__dirname),
Review comment:
Maybe make this `path.resolve(__dirname, 'dist')` and that makes the gitignore easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] Treora merged pull request #67: Reorganise
webpack-related files
Posted by GitBox <gi...@apache.org>.
Treora merged pull request #67: Reorganise webpack-related files
URL: https://github.com/apache/incubator-annotator/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator] Treora commented on a change in pull request
#67: Reorganise webpack-related files
Posted by GitBox <gi...@apache.org>.
Treora commented on a change in pull request #67: Reorganise webpack-related files
URL: https://github.com/apache/incubator-annotator/pull/67#discussion_r399801960
##########
File path: web/webpack.config.js
##########
@@ -43,7 +46,7 @@ module.exports = {
],
},
output: {
- filename: '[name].js',
- publicPath: '/',
+ path: path.resolve(__dirname),
Review comment:
Yes, an output folder has my preference as well; it’s just really hard to get webpack to also move the html files into that output folder, and I would like html and js files to stick together. I made it work now; if we add more demo pages/files, I would consider trying out [Parcel](https://parceljs.org/) to see whether it better supports such an html-first instead of javascript-first approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services