[jira] [Commented] (KAFKA-5291) AdminClient should not trigger auto creation of topics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017222#comment-16017222 ] 

ASF GitHub Bot commented on KAFKA-5291:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3098

    KAFKA-5291: AdminClient should not trigger auto creation of topics

    - Added a boolean allow_auto_topic_creation to MetadataRequest.
    I didn’t bump the version a second time since we did it once for this
    release already, but this needs to be verified.
    
    - Set it to false in the new AdminClient and StreamsKafkaClient
    (which exists for the purpose of creating topics manually); set it
    to true everywhere else for now. Other clients will eventually
    rely on client-side auto topic creation, but that’s not there yet.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-5291-admin-client-no-auto-topic-creation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3098
    
----

----


> AdminClient should not trigger auto creation of topics
> ------------------------------------------------------
>
>                 Key: KAFKA-5291
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5291
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.11.0.0
>
>
> Feedback from people who tried the AdminClient is that auto topic creation during describe is very confusing. We expected that, but we also thought that there wasn't much that could be done.
> However, there's a simple solution (suggested by [~hachikuji]): make it possible to disallow auto topic creation when sending the metadata request. We can keep the existing behaviour for the producer and consumer (until we move to client-side auto topic creation) while doing the right thing for AdminClient (which is new).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)