You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/06/20 01:26:42 UTC
Review Request: Do not use 'function' in Bourne shell scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5427/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
The deploy scripts use 'function foo() { ... }' instead of 'foo () { ... }'. The former syntax is a bash (and others) extension, not supported by POSIX sh.
Diffs
-----
src/deploy/mesos-start-cluster.sh.in a4bd881
src/deploy/mesos-stop-cluster.sh.in 9d5a4b3
Diff: https://reviews.apache.org/r/5427/diff/
Testing
-------
Thanks,
Charles Reiss
Re: Review Request: Do not use 'function' in Bourne shell scripts
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5427/#review9028
-----------------------------------------------------------
Ship it!
Thanks Charles.
- Benjamin Hindman
On June 19, 2012, 11:26 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5427/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 11:26 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> The deploy scripts use 'function foo() { ... }' instead of 'foo () { ... }'. The former syntax is a bash (and others) extension, not supported by POSIX sh.
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in a4bd881
> src/deploy/mesos-stop-cluster.sh.in 9d5a4b3
>
> Diff: https://reviews.apache.org/r/5427/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Do not use 'function' in Bourne shell scripts
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5427/#review9029
-----------------------------------------------------------
Ship it!
Thanks Charles.
- Benjamin Hindman
On June 19, 2012, 11:26 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5427/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 11:26 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> The deploy scripts use 'function foo() { ... }' instead of 'foo () { ... }'. The former syntax is a bash (and others) extension, not supported by POSIX sh.
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in a4bd881
> src/deploy/mesos-stop-cluster.sh.in 9d5a4b3
>
> Diff: https://reviews.apache.org/r/5427/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>