[jira] [Commented] (MAPREDUCE-6660) Add MR Counters for bytes-read-by-network-distance FileSystem metrics

["Junping Du (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233200#comment-15233200 ] 

Junping Du commented on MAPREDUCE-6660:
---------------------------------------

Thanks [~mingma] for delivering the patch! Quickly go through patch, and a few comments:
1. About naming of new FileSystemCounter:
{noformat}
+  BYTES_READ_LOCAL_HOST,
+  BYTES_READ_LOCAL_RACK,
+  BYTES_READ_FIRST_DEGREE_REMOTE_RACK,
+  BYTES_READ_SECOND_OR_MORE_DEGREE_REMOTE_RACK,
{noformat}
Shall we just simply name it as: BYTES_READ_LOCAL_HOST,  BYTES_READ_LOCAL_RACK,  BYTES_READ_LOCAL_DATACENTER, BYTES_READ_REMOTE_DATACENTER and put some comments on it? I think it sounds more understandable. 
BTW, the last comma is not necessary.

Also, shall we add some simple test to verify number of BYTES_READ = sum of 4 new read counters?


 

> Add MR Counters for bytes-read-by-network-distance FileSystem metrics
> ---------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6660
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6660
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: MAPREDUCE-6660.patch, MAPREDUCE-6660.png
>
>
> This is the MR part of the change which is to consume bytes-read-by-network-distance metrics generated by https://issues.apache.org/jira/browse/HDFS-9579.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)