You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/16 13:06:14 UTC
[GitHub] zentol commented on a change in pull request #7303: [FLINK-10569]
[tests] Get rid of Scheduler from valid tests
zentol commented on a change in pull request #7303: [FLINK-10569] [tests] Get rid of Scheduler from valid tests
URL: https://github.com/apache/flink/pull/7303#discussion_r248273256
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/VertexSlotSharingTest.java
##########
@@ -90,12 +90,12 @@ public void testAssignSlotSharingGroup() {
new SerializedValue<>(new ExecutionConfig()),
AkkaUtils.getDefaultTimeout(),
new NoRestartStrategy(),
- new Scheduler(TestingUtils.defaultExecutionContext()));
+ new TestingSlotProvider(ignored -> new CompletableFuture<>()));
eg.attachJobGraph(vertices);
// verify that the vertices are all in the same slot sharing group
- SlotSharingGroup group1 = null;
- SlotSharingGroup group2 = null;
+ SlotSharingGroup group1;
Review comment:
I would revert this as I wouldn't even categorize this as code-cleanup. Whether to keep these uninitialized or not is more or less personal preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services