[GitHub] [incubator-pinot] mqliang commented on a change in pull request #7091: Added TaskMetricsEmitted periodic controller job

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #7091:
URL: https://github.com/apache/incubator-pinot/pull/7091#discussion_r658472544



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/TaskMetricsEmitter.java
##########
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.controller.helix.core.minion;
+
+import java.util.Set;
+import org.apache.pinot.common.metrics.ControllerGauge;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.controller.ControllerConf;
+import org.apache.pinot.controller.LeadControllerManager;
+import org.apache.pinot.controller.helix.core.minion.PinotHelixTaskResourceManager.TaskCount;
+import org.apache.pinot.core.periodictask.BasePeriodicTask;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class TaskMetricsEmitter extends BasePeriodicTask {
+  private static final Logger LOGGER = LoggerFactory.getLogger(TaskMetricsEmitter.class);
+  private final static String TASK_NAME = "TaskMetricsEmitter";
+
+  private final PinotHelixTaskResourceManager _helixTaskResourceManager;
+  private final ControllerMetrics _controllerMetrics;
+  private final LeadControllerManager _leadControllerManager;
+
+  public TaskMetricsEmitter(PinotHelixTaskResourceManager helixTaskResourceManager,
+      LeadControllerManager leadControllerManager, ControllerConf controllerConf, ControllerMetrics controllerMetrics) {
+    super(TASK_NAME, controllerConf.getTaskMetricsEmitterFrequencyInSeconds(),
+        controllerConf.getPeriodicTaskInitialDelayInSeconds());
+    _helixTaskResourceManager = helixTaskResourceManager;
+    _controllerMetrics = controllerMetrics;
+    _leadControllerManager = leadControllerManager;
+  }
+
+  @Override
+  protected final void runTask() {
+    // Make it so that only one controller returns the metric for all the tasks.
+    if (!_leadControllerManager.isLeaderForTable(TASK_NAME)) {
+      return;
+    }
+
+    // The call to get task types can take time if there are a lot of tasks.
+    // Potential optimization is to call it every (say) 30m if we detect a barrage of
+    // zk requests.
+    Set<String> taskTypes = _helixTaskResourceManager.getTaskTypes();
+    for (String taskType : taskTypes) {
+      TaskCount accumulated = new TaskCount();
+      Set<String> tasksInProgress = _helixTaskResourceManager.getTasksInProgress(taskType);
+      int numRunningTasks = 0;
+      for (String task : tasksInProgress) {
+        numRunningTasks++;

Review comment:
       Instead of `numRunningTasks++;` in for loop, how about declare `int numRunningTasks = tasksInProgress.size()` out of the for loop?

##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
##########
@@ -258,6 +262,50 @@ public synchronized String submitTask(List<PinotTaskConfig> pinotTaskConfigs, St
     return taskStates;
   }
 
+  /**
+   * This method helps compute the percentage done for a task (that may have many partitions or sub-tasks).
+   * @param parentTaskName (e.g. "Task_TestTask_1624403781879")
+   * @return a pair of integers, first one being the total number partitions and the second being number of partitions
+   * still running or yet to run.
+   */
+  public synchronized TaskCount getTaskCount(String parentTaskName) {
+    JobContext jobContext = _taskDriver.getJobContext(getHelixJobName(parentTaskName));
+    TaskCount taskCount = new TaskCount();
+    for (int partition : jobContext.getPartitionSet()) {
+      taskCount.addToTotal(1);

Review comment:
       `taskCount.addToTotal(jobContext.getPartitionSet().size());` out of the for loop?

##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
##########
@@ -258,6 +262,50 @@ public synchronized String submitTask(List<PinotTaskConfig> pinotTaskConfigs, St
     return taskStates;
   }
 
+  /**
+   * This method helps compute the percentage done for a task (that may have many partitions or sub-tasks).
+   * @param parentTaskName (e.g. "Task_TestTask_1624403781879")
+   * @return a pair of integers, first one being the total number partitions and the second being number of partitions

Review comment:
       Please update the javadoc of return type here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org