You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Jesse Pangburn (JIRA)" <ji...@apache.org> on 2011/08/22 23:06:29 UTC

[jira] [Created] (CXF-3755) setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API

setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API
-------------------------------------------------------------------------------------------------------

                 Key: CXF-3755
                 URL: https://issues.apache.org/jira/browse/CXF-3755
             Project: CXF
          Issue Type: Bug
          Components: JAX-WS Runtime
    Affects Versions: 2.4.1
            Reporter: Jesse Pangburn
            Priority: Minor


I configured ws addressing on the cxf bus like this, instead of adding the feature directly to the dispatch client:
<cxf:bus>
	<cxf:features>
		<wsa:addressing/>
	</cxf:features>
</cxf:bus>

However using both SOAP 1.1 and 1.2 Dispatch API clients, I found that it sets the wrong Action header by just using a default rather than the one from the WSDL.  I'm not certain which code is responsible for this but I see in the DispatchImpl.java the following code:
boolean wsaEnabled = false;
for (AbstractFeature feature : ((JaxWsClientEndpointImpl)client.getEndpoint()).getFeatures()) {
  if (feature instanceof WSAddressingFeature) {
    wsaEnabled = true; 
  }
}

This only looks for the features on the endpoint to determine if it should do ws addressing, not the features on the bus too.  So the DispatchImpl doesn't set this stuff up.  Further investigation shows that if the wsAddressing feature is added via jaxws:client spring configuration, the action header is wrong here too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3755) setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API

Posted by "Jesse Pangburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Pangburn updated CXF-3755:
--------------------------------

    Attachment: patch3754_partial_and3755.txt

The attached patch file fixes this bug (3755) and also includes the patch for 3754 because 3754 required a change to the same file which I cannot commit separately.

> setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3755
>                 URL: https://issues.apache.org/jira/browse/CXF-3755
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Priority: Minor
>              Labels: dispatch, jaxws, ws-addressing
>         Attachments: patch3754_partial_and3755.txt
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> I configured ws addressing on the cxf bus like this, instead of adding the feature directly to the dispatch client:
> <cxf:bus>
> 	<cxf:features>
> 		<wsa:addressing/>
> 	</cxf:features>
> </cxf:bus>
> However using both SOAP 1.1 and 1.2 Dispatch API clients, I found that it sets the wrong Action header by just using a default rather than the one from the WSDL.  I'm not certain which code is responsible for this but I see in the DispatchImpl.java the following code:
> boolean wsaEnabled = false;
> for (AbstractFeature feature : ((JaxWsClientEndpointImpl)client.getEndpoint()).getFeatures()) {
>   if (feature instanceof WSAddressingFeature) {
>     wsaEnabled = true; 
>   }
> }
> This only looks for the features on the endpoint to determine if it should do ws addressing, not the features on the bus too.  So the DispatchImpl doesn't set this stuff up.  Further investigation shows that if the wsAddressing feature is added via jaxws:client spring configuration, the action header is wrong here too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CXF-3755) setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API

Posted by "Jesse Pangburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Pangburn closed CXF-3755.
-------------------------------


Verified by downloading latest version of affected file(s) from SVN on the 2.4.x fixes branch, building CXF 2.4.2 with the fixed file(s) and testing this defect

> setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3755
>                 URL: https://issues.apache.org/jira/browse/CXF-3755
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, ws-addressing
>             Fix For: 2.3.7, 2.4.3
>
>         Attachments: patch3754_partial_and3755.txt, patch3754and3755.txt
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> I configured ws addressing on the cxf bus like this, instead of adding the feature directly to the dispatch client:
> <cxf:bus>
> 	<cxf:features>
> 		<wsa:addressing/>
> 	</cxf:features>
> </cxf:bus>
> However using both SOAP 1.1 and 1.2 Dispatch API clients, I found that it sets the wrong Action header by just using a default rather than the one from the WSDL.  I'm not certain which code is responsible for this but I see in the DispatchImpl.java the following code:
> boolean wsaEnabled = false;
> for (AbstractFeature feature : ((JaxWsClientEndpointImpl)client.getEndpoint()).getFeatures()) {
>   if (feature instanceof WSAddressingFeature) {
>     wsaEnabled = true; 
>   }
> }
> This only looks for the features on the endpoint to determine if it should do ws addressing, not the features on the bus too.  So the DispatchImpl doesn't set this stuff up.  Further investigation shows that if the wsAddressing feature is added via jaxws:client spring configuration, the action header is wrong here too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3755) setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API

Posted by "Jesse Pangburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Pangburn updated CXF-3755:
--------------------------------

    Attachment: patch3754and3755.txt

The attached patch file fixes this bug (3755) and also includes the full patch for 3754 because 3754 required a change to the same file which I cannot commit separately.
Previously attached patch file only had the partial fix for 3754.

> setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3755
>                 URL: https://issues.apache.org/jira/browse/CXF-3755
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Priority: Minor
>              Labels: dispatch, jaxws, ws-addressing
>         Attachments: patch3754_partial_and3755.txt, patch3754and3755.txt
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> I configured ws addressing on the cxf bus like this, instead of adding the feature directly to the dispatch client:
> <cxf:bus>
> 	<cxf:features>
> 		<wsa:addressing/>
> 	</cxf:features>
> </cxf:bus>
> However using both SOAP 1.1 and 1.2 Dispatch API clients, I found that it sets the wrong Action header by just using a default rather than the one from the WSDL.  I'm not certain which code is responsible for this but I see in the DispatchImpl.java the following code:
> boolean wsaEnabled = false;
> for (AbstractFeature feature : ((JaxWsClientEndpointImpl)client.getEndpoint()).getFeatures()) {
>   if (feature instanceof WSAddressingFeature) {
>     wsaEnabled = true; 
>   }
> }
> This only looks for the features on the endpoint to determine if it should do ws addressing, not the features on the bus too.  So the DispatchImpl doesn't set this stuff up.  Further investigation shows that if the wsAddressing feature is added via jaxws:client spring configuration, the action header is wrong here too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CXF-3755) setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-3755.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4.3
                   2.3.7
         Assignee: Daniel Kulp

> setting wsa:addressing feature in cxf:bus causes wrong action header to be sent when using Dispatch API
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3755
>                 URL: https://issues.apache.org/jira/browse/CXF-3755
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, ws-addressing
>             Fix For: 2.3.7, 2.4.3
>
>         Attachments: patch3754_partial_and3755.txt, patch3754and3755.txt
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> I configured ws addressing on the cxf bus like this, instead of adding the feature directly to the dispatch client:
> <cxf:bus>
> 	<cxf:features>
> 		<wsa:addressing/>
> 	</cxf:features>
> </cxf:bus>
> However using both SOAP 1.1 and 1.2 Dispatch API clients, I found that it sets the wrong Action header by just using a default rather than the one from the WSDL.  I'm not certain which code is responsible for this but I see in the DispatchImpl.java the following code:
> boolean wsaEnabled = false;
> for (AbstractFeature feature : ((JaxWsClientEndpointImpl)client.getEndpoint()).getFeatures()) {
>   if (feature instanceof WSAddressingFeature) {
>     wsaEnabled = true; 
>   }
> }
> This only looks for the features on the endpoint to determine if it should do ws addressing, not the features on the bus too.  So the DispatchImpl doesn't set this stuff up.  Further investigation shows that if the wsAddressing feature is added via jaxws:client spring configuration, the action header is wrong here too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira