You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 18:11:39 UTC

[jira] [Created] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

The Label Manager is wrongly overriding CommonEmptyHeader
---------------------------------------------------------

                 Key: OFBIZ-4652
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release 10.04, Release 09.04, Release Branch 11.04, SVN trunk
            Reporter: Jacques Le Roux


So 
<xml:lang="en" xml:space="preserve">
is replaced by
<value xml:lang="en" xml:space="preserve"/> 

We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by Pierre Smits <pi...@gmail.com>.
I use CommenEmptyHeader in overviews where I provide icons as buttons to
actions.

Regards,

Pierre

2012/5/3 Jacques Le Roux (JIRA) <ji...@apache.org>

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267277#comment-13267277]
>
> Jacques Le Roux commented on OFBIZ-4652:
> ----------------------------------------
>
> Why this label is needed is explained at
> http://markmail.org/message/42mp6djd546ici7g (part of the thread I
> referred about above). I think I have an idea to keep CommonEmptyHeader and
> address this issue. CommonEmptyHeader can be used in other cases and as
> proven be helpful in some projects already: we should keep it.
>
> > The Label Manager is wrongly overriding CommonEmptyHeader
> > ---------------------------------------------------------
> >
> >                 Key: OFBIZ-4652
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
> >             Project: OFBiz
> >          Issue Type: Bug
> >          Components: framework
> >    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04,
> SVN trunk
> >            Reporter: Jacques Le Roux
> >              Labels: labe, manager
> >
> > So
> > <xml:lang="en" xml:space="preserve">
> > is replaced by
> > <value xml:lang="en" xml:space="preserve"/>
> > We shoul also add </value><!-- do not  remove this! --> to docvument the
> feature (todo better, more a reminder)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276539#comment-13276539 ] 

Adrian Crum commented on OFBIZ-4652:
------------------------------------

Jacques, that email link describes what needs to be fixed, NOT why it should stay that way.

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276619#comment-13276619 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

I reverted all (trunk and r12.04), because it would break the correct indentation done by UtilXml.writeXmlDocument()
We will rather try this (quoting Adrian)
{quote}
There is a chance the XML parser treats an attribute containing a single space as an empty attribute. If that is the case, then the widget schemas can be updated to prevent that interpretation.
{quote}
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267277#comment-13267277 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Why this label is needed is explained at http://markmail.org/message/42mp6djd546ici7g (part of the thread I referred about above). I think I have an idea to keep CommonEmptyHeader and address this issue. CommonEmptyHeader can be used in other cases and as proven be helpful in some projects already: we should keep it.
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276550#comment-13276550 ] 

Jacques Le Roux edited comment on OFBIZ-4652 at 5/16/12 7:30 AM:
-----------------------------------------------------------------

== TYPO ==
Hi Adrian,

Answered on dev ML :)
                
      was (Author: jacques.le.roux):
    Hi Adrian,

Answered on de ML :)
                  
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183966#comment-13183966 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Yes you are right, it's my own wrong interpretation of http://www.w3.org/TR/REC-xml/#sec-white-space. I thought it would solve the problem at hand, when it actually does anything. This should be specifically handled in Label Manager code.

I think it's interesting to keep history here:
http://markmail.org/message/nrovxy6zxejjoqfk
https://issues.apache.org/jira/browse/OFBIZ-2349
http://svn.apache.org/viewvc?view=revision&revision=768123
https://issues.apache.org/jira/browse/OFBIZ-2171?focusedCommentId=12671931&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12671931
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?view=diff&r1=768194&r2=768195&pathrev=768195
http://svn.apache.org/viewvc?view=revision&revision=767845
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?r1=768195&r2=768194&pathrev=768195

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4652.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Fixed in
trunk r1338831
R12.04 r1338836
R11.04 r1338842
R10.04 r1338843

* Adds a keepSpace boolean to UtilXml.writeXmlDocument(), this allows to use xsl:preserve-space into UtilXml.createOutputTransformer()
* Uses it into SaveLabelsToXmlFile.saveLabelsToXmlFile()
* Adds some French labels into CommonUiLabels.xml using Labels Manager to test the new functionality 
* Adds the xml:space attribute into the valueType complexType
* Adds the ofbiz-properties.xsd schema into the base-catalog.xml

I got an issue when 1st trying to commit: 
Commit failed (details follow):
While preparing
 'D:\workspace\ofbizClean\framework\common\config\CommonUiLabels.xml' for commit
Inconsistent line ending style

So I forced the EOLs to my locale platform value (Win XP)

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263707#comment-13263707 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Yes I tend to agree, I will try to check that...
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276133#comment-13276133 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Forgot to and clean, fixed and completed at
trunk r1338845
r12.04 r1338847
r11.04 r1338846
r10.04 r1338848

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263675#comment-13263675 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

We still need a solution here. Else we have a problem when editing a label of CommonUiLabels.xml with the Labels Manager...
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Adrian Crum (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183407#comment-13183407 ] 

Adrian Crum commented on OFBIZ-4652:
------------------------------------

I never understood the point of the CommonEmptyHeader property. If the only value it will ever contain is a single space, then why not use a single space instead of a UI label property?

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276133#comment-13276133 ] 

Jacques Le Roux edited comment on OFBIZ-4652 at 5/15/12 7:29 PM:
-----------------------------------------------------------------

== TYPO ==
Forgot to ant clean, fixed and completed at
trunk r1338845
r12.04 r1338847
r11.04 r1338846
r10.04 r1338848

                
      was (Author: jacques.le.roux):
    Forgot to and clean, fixed and completed at
trunk r1338845
r12.04 r1338847
r11.04 r1338846
r10.04 r1338848

                  
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276550#comment-13276550 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Hi Adrian,

Answered on de ML :)
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279493#comment-13279493 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Definitevely closed in trunk at r1340372. We simply need to replace title="${uiLabelMap.CommonEmptyHeader}" by title=" ", even if this must be done carefully...

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263682#comment-13263682 ] 

Adrian Crum commented on OFBIZ-4652:
------------------------------------

I believe the ideal solution would be to find out why the label is needed, and fix the code that depends on it - so the label is not needed any more.

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>              Labels: labe, manager
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276404#comment-13276404 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

On Scott's recommendation I have deprecated w/out keepSpace versions of UtilXml.createOutputTransformer() and UtilXml.writeXmlDocument() in trunk and R12.04 at respectively r1338974 and r1338976. I have reverted from released branches (ie R11.04 and R10.04), deprecation should not be backported
                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276147#comment-13276147 ] 

Jacques Le Roux commented on OFBIZ-4652:
----------------------------------------

Arg, I should have used the Eclipse refactor feature :/
Definitively fixed and completed at
trunk r1338856
R12.04 r1338859
R11.04 r1338858
R10.04 r1338860






                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira