You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2012/06/09 17:26:41 UTC

abort on 'svn st'

Hi,

Another one from the TSVN crash reports:

Several reports because of a call to SVN_ERR_MALFUNCTION_NO_RETURN() 
when doing an 'svn st'. Stacktrace attached.

The call is in libsvn_subr/token.c:51

int
svn_token__from_word_strict(const svn_token_map_t *map,
                             const char *word)
{
   int value = svn_token__from_word(map, word);

   if (value == SVN_TOKEN_UNKNOWN)
     SVN_ERR_MALFUNCTION_NO_RETURN();

   return value;
}


but there's already a function svn_token__from_word_err() which does not 
abort but return an error.

For an operation that's maybe the most used one (svn st) I'd rather have 
an error than an abort().

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net