You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/02 15:48:54 UTC
Review Request 38954: change nimbus.monitor.freq.secs=120 in ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38954/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
Bugs: AMBARI-13297
https://issues.apache.org/jira/browse/AMBARI-13297
Repository: ambari
Description
-------
we decided nimbus.monitor.freq.secs=120 and committed to 2.3-maint
But found that on ambari installed clusters are having nimbus.monitor.freq.secs=10
which many times causes storm-hive integration tests to fail.
And mannually setting nimbus.monitor.freq.secs=120 and restarting nimbus causes tests to pass
So change nimbus.monitor.freq.secs to 120
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 2fa4275
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 5055a67
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7d1f6ee
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/38954/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 38954: change nimbus.monitor.freq.secs=120 in
ambari
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38954/#review101319
-----------------------------------------------------------
Ship it!
Review looks fine; I did put 2 "Fix It's" because I just wasn't sure when we should be changing this value. If it's already set to 5 in an environment by an administrator, do we want to change it? What if it's missing? If the answers are "no", then feel free to resolve the opened issues.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 123)
<https://reviews.apache.org/r/38954/#comment158692>
What if the value is missing - do we want to set it? If not, please drop the issue.
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml (line 159)
<https://reviews.apache.org/r/38954/#comment158693>
The upgrade pack to 2.3 has this value, but here you're setting it on the common services config. Should this only be set in HDP/2.3 ? If not, please drop the issue.
- Jonathan Hurley
On Oct. 2, 2015, 9:49 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38954/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 9:49 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
>
>
> Bugs: AMBARI-13297
> https://issues.apache.org/jira/browse/AMBARI-13297
>
>
> Repository: ambari
>
>
> Description
> -------
>
> we decided nimbus.monitor.freq.secs=120 and committed to 2.3-maint
>
> But found that on ambari installed clusters are having nimbus.monitor.freq.secs=10
> which many times causes storm-hive integration tests to fail.
> And mannually setting nimbus.monitor.freq.secs=120 and restarting nimbus causes tests to pass
>
> So change nimbus.monitor.freq.secs to 120
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 2fa4275
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 5055a67
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7d1f6ee
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38954/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 38954: change nimbus.monitor.freq.secs=120 in
ambari
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38954/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 1:49 p.m.)
Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
Bugs: AMBARI-13297
https://issues.apache.org/jira/browse/AMBARI-13297
Repository: ambari
Description
-------
we decided nimbus.monitor.freq.secs=120 and committed to 2.3-maint
But found that on ambari installed clusters are having nimbus.monitor.freq.secs=10
which many times causes storm-hive integration tests to fail.
And mannually setting nimbus.monitor.freq.secs=120 and restarting nimbus causes tests to pass
So change nimbus.monitor.freq.secs to 120
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 2fa4275
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 5055a67
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7d1f6ee
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/38954/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko